Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add teal.reporter into tmh modules #238

Closed
Tracked by #11
nikolas-burkoff opened this issue May 19, 2022 · 7 comments · Fixed by #265
Closed
Tracked by #11

Add teal.reporter into tmh modules #238

nikolas-burkoff opened this issue May 19, 2022 · 7 comments · Fixed by #265
Assignees
Labels
core enhancement New feature or request

Comments

@nikolas-burkoff
Copy link
Contributor

nikolas-burkoff commented May 19, 2022

@danielinteractive
Copy link
Collaborator

@nikolas-burkoff does it involve chunks business? or not?

@nikolas-burkoff
Copy link
Contributor Author

It does not

@danielinteractive
Copy link
Collaborator

very good :-) then yes please :-)

@nikolas-burkoff
Copy link
Contributor Author

nikolas-burkoff commented May 19, 2022

It would involve adding

See the bit inside ### Reporter ### in this example app insightsengineering/teal#635 (comment) and also the example here https://github.com/insightsengineering/teal.reporter/blob/fba8c9b993e152a490556cf1e2a61ec285bd6122/vignettes/previewerReporter.Rmd#L136 (which is more complex as it has a switch statement to capture three different outputs)

@danielinteractive
Copy link
Collaborator

thx @nikolas-burkoff yeah if core team can drive this then I am happy to chat about what to record etc.

@kpagacz kpagacz changed the title Add teal.reporting into tmh modules Add teal.reporter into tmh modules May 20, 2022
@mhallal1
Copy link
Collaborator

mhallal1 commented Jul 8, 2022

@danielinteractive Could you list the specific encodings that are needed for every module to be included in the report?
For instance: insightsengineering/teal.osprey#140 (comment)

@danielinteractive
Copy link
Collaborator

@mhallal1 maybe it is easiest just to include all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants