Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply facet rule only when supplied #599

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Apply facet rule only when supplied #599

merged 4 commits into from
Nov 20, 2023

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Nov 10, 2023

Closes #595

@vedhav vedhav added bug Something isn't working core labels Nov 10, 2023
Copy link
Contributor

github-actions bot commented Nov 10, 2023

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ----------------------------------------------
R/tm_a_pca.R                    829     829  0.00%    72-1025
R/tm_a_regression.R             716     716  0.00%    96-895
R/tm_data_table.R               171     171  0.00%    62-285
R/tm_file_viewer.R              172     172  0.00%    42-244
R/tm_front_page.R               127     116  8.66%    65-207
R/tm_g_association.R            333     333  0.00%    92-483
R/tm_g_bivariate.R              655     495  24.43%   128-709, 757, 763, 767, 878, 895, 913, 933-955
R/tm_g_distribution.R          1028    1028  0.00%    122-1272
R/tm_g_response.R               351     351  0.00%    88-503
R/tm_g_scatterplot.R            719     719  0.00%    163-973
R/tm_g_scatterplotmatrix.R      280     261  6.79%    80-377, 431, 445
R/tm_missing_data.R            1044    1044  0.00%    60-1241
R/tm_outliers.R                 976     976  0.00%    78-1183
R/tm_t_crosstable.R             254     254  0.00%    83-375
R/tm_variable_browser.R         833     828  0.60%    63-1327
R/utils.R                       122     122  0.00%    74-351
R/zzz.R                           1       1  0.00%    2
TOTAL                          8611    8416  2.26%

Diff against main

Filename             Stmts    Miss  Cover
-----------------  -------  ------  --------
R/tm_g_response.R       +2      +2  +100.00%
TOTAL                   +2      +2  -0.00%

Results for commit: a779821

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Nov 10, 2023

Unit Tests Summary

  1 files    5 suites   0s ⏱️
16 tests 16 ✔️ 0 💤 0
49 runs  49 ✔️ 0 💤 0

Results for commit a779821.

♻️ This comment has been updated with latest results.

@vedhav
Copy link
Contributor Author

vedhav commented Nov 10, 2023

We can ignore the CRAN check failure. It will go away after we merge the other PR #597

Copy link
Contributor

@chlebowa chlebowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@m7pr
Copy link
Contributor

m7pr commented Nov 15, 2023

@vedhav I think you can always change the base of this PR to #597 and merge there

@vedhav vedhav merged commit 28d04b0 into main Nov 20, 2023
24 checks passed
@vedhav vedhav deleted the 595-fix-validation-error branch November 20, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: tm_g_response module - attempt to apply non-function to row_facet and col_facet
3 participants