Apply facet rule only when supplied (#599)

Closes #595
insightsengineering · Nov 20, 2023 · 28d04b0 · 28d04b0
1 parent f1a3014
commit 28d04b0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,4 +1,4 @@
-# teal.modules.general 0.2.16.9010
+# teal.modules.general 0.2.16.9011
 
 ### Enhancements
 

diff --git a/R/tm_g_response.R b/R/tm_g_response.R
@@ -238,10 +238,12 @@ srv_g_response <- function(id,
 
     rule_diff <- function(other) {
       function(value) {
-        othervalue <- selector_list()[[other]]()[["select"]]
-        if (!is.null(othervalue)) {
-          if (identical(value, othervalue)) {
-            "Row and column facetting variables must be different."
+        if (other %in% names(selector_list())) {
+          othervalue <- selector_list()[[other]]()[["select"]]
+          if (!is.null(othervalue)) {
+            if (identical(value, othervalue)) {
+              "Row and column facetting variables must be different."
+            }
           }
         }
       }