-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs to use the new teal_data
instead of TealData
#597
Merged
vedhav
merged 14 commits into
main
from
591-migrate-to-teal_data@78_simplify_joinkeys@main
Nov 20, 2023
Merged
Update docs to use the new teal_data
instead of TealData
#597
vedhav
merged 14 commits into
main
from
591-migrate-to-teal_data@78_simplify_joinkeys@main
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Summary
Diff against main
Results for commit: c769c01 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
This was referenced Nov 9, 2023
gogonzo
reviewed
Nov 13, 2023
vedhav
force-pushed
the
591-migrate-to-teal_data@78_simplify_joinkeys@main
branch
from
November 15, 2023 10:39
8e453c0
to
efe3e2c
Compare
kartikeyakirar
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Not needed for getters but it's nice to use the same getters too
vedhav
deleted the
591-migrate-to-teal_data@78_simplify_joinkeys@main
branch
November 20, 2023 11:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #591 and also use the new
join_keys
functions and methods part of the teal.data PR #184