-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce decorators for tm_g_barchart_simple
#1267
introduce decorators for tm_g_barchart_simple
#1267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code works and looks good. It is nice that this module that have multiple decorators was documented showing how to do it and that the example also have both of them.
To see the caption on my machine I have to preview the cards, and I realized the reporter preview doesn't show the table:
This might be out of scope of the PR, but I'm curious if the table should also show on the card. The code reported has a table statement at the end, so I would expect it to show up.
…87_decorate_output@main
…87_decorate_output@main
…87_decorate_output@main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two minor comments, I modified the example to be able to run it as is.
If working locally you'll need to pull the code as I messed it with the local branch I had and reverted it back.
Co-authored-by: Lluís Revilla <[email protected]> Signed-off-by: André Veríssimo <[email protected]>
…87_decorate_output@main
Part of insightsengineering/teal#1371
Checklist for final review:
#' @param decorators `r roxygen_decorators_param("tm_X_XXX")`
assert_decorators
function (null.ok = TRUE
is sometimes second argument and looks better at 3^rd)Example
Working Example