Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wave 1 - tm_a_gee shinytests #1139

Merged
merged 19 commits into from
Apr 26, 2024
Merged

Wave 1 - tm_a_gee shinytests #1139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
8a980e1
setup for tm_a_gee tests
m7pr Apr 22, 2024
6d291fa
input tests
m7pr Apr 22, 2024
c040894
tests for tables content
m7pr Apr 22, 2024
6cf72f6
tests for more input params
m7pr Apr 22, 2024
1bbc53a
remaining tests cof last 3 widgets
m7pr Apr 22, 2024
a98e360
Update tests/testthat/test-shinytest2-tm_a_gee.R
m7pr Apr 23, 2024
c03f916
@gogonzo comments + typos
m7pr Apr 23, 2024
54a794f
cleanup test names
m7pr Apr 24, 2024
72f874b
Update tests/testthat/test-shinytest2-tm_a_gee.R
m7pr Apr 24, 2024
4ce6801
Update tests/testthat/test-shinytest2-tm_a_gee.R
m7pr Apr 24, 2024
7b40b9d
use get_active_module_tws_output
m7pr Apr 24, 2024
80c73ce
shorten tests
m7pr Apr 24, 2024
d981309
fix lintr
m7pr Apr 24, 2024
6f8fa51
tests indentation
m7pr Apr 25, 2024
885f54b
1108 shinytest2 tm a gee@shinytest2@main (#1142)
m7pr Apr 26, 2024
b6da85b
this is insane
m7pr Apr 26, 2024
bd3e004
running styler::style_file("tests/testthat/test-shinytest2-tm_a_gee.R")
m7pr Apr 26, 2024
4febb76
use ns_des_input
m7pr Apr 26, 2024
c9a2ee6
Merge branch 'shinytest2@main' into 1108_shinytest2_tm_a_gee-rebased@…
m7pr Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions tests/testthat/helper-TealAppDriver.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,3 @@ init_teal_app_driver <- function(...) {
ns_des_input <- function(id, dataname, type) {
sprintf("%s-dataset_%s_singleextract-%s", id, dataname, type)
}

# returns base 64 encoded image
active_module_pws_output <- function(app_driver) {
app_driver$get_attr(
app_driver$active_module_element("myplot-plot_main > img"),
"src"
)
}
93 changes: 39 additions & 54 deletions tests/testthat/test-shinytest2-tm_a_gee.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,26 +61,26 @@ testthat::test_that(
)

testthat::expect_equal(
app_driver$get_active_module_input("aval_var-dataset_ADQS_singleextract-select"),
app_driver$get_active_module_input(ns_des_input("aval_var", "ADQS", "select")),
"AVALBIN"
)

testthat::expect_equal(
app_driver$get_active_module_input("id_var-dataset_ADQS_singleextract-select"),
app_driver$get_active_module_input(ns_des_input("id_var", "ADQS", "select")),
"USUBJID"
)

testthat::expect_equal(
app_driver$get_active_module_input("arm_var-dataset_ADSL_singleextract-select"),
app_driver$get_active_module_input(ns_des_input("arm_var", "ADSL", "select")),
"ARM"
)

testthat::expect_equal(
app_driver$get_active_module_input("visit_var-dataset_ADQS_singleextract-select"),
app_driver$get_active_module_input(ns_des_input("visit_var", "ADQS", "select")),
"AVISIT"
)
testthat::expect_equal(
app_driver$get_active_module_input("paramcd-dataset_ADQS_singleextract-filter1-vals"),
app_driver$get_active_module_input(ns_des_input("paramcd", "ADQS", "filter1-vals")),
"FKSI-FWB"
)

Expand All @@ -103,20 +103,23 @@ testthat::test_that(
}
)

testthat::test_that("e2e - tm_a_gee: Selection of id_var changes the table and does not throw validation errors.", {
skip_if_too_deep(5)
app_driver <- app_driver_tm_a_gee()
table_before <- app_driver$get_active_module_tws_output("table")
app_driver$set_active_module_input("id_var-dataset_ADQS_singleextract-select", "SUBJID")
testthat::expect_false(identical(table_before, app_driver$get_active_module_tws_output("table")))
app_driver$expect_no_validation_error()
app_driver$stop()
})
testthat::test_that(
"e2e - tm_a_gee: Selection of id_var does not change the table and does not throw validation errors.",
{
skip_if_too_deep(5)
app_driver <- app_driver_tm_a_gee()
table_before <- app_driver$get_active_module_tws_output("table")
app_driver$set_active_module_input(ns_des_input("id_var", "ADQS", "select"), "SUBJID")
testthat::expect_true(identical(table_before, app_driver$get_active_module_tws_output("table")))
app_driver$expect_no_validation_error()
app_driver$stop()
}
)

testthat::test_that("e2e - tm_a_gee: Deselection of id_var throws validation error.", {
skip_if_too_deep(5)
app_driver <- app_driver_tm_a_gee()
app_driver$set_active_module_input("id_var-dataset_ADQS_singleextract-select", character(0))
app_driver$set_active_module_input(ns_des_input("id_var", "ADQS", "select"), character(0))
testthat::expect_identical(app_driver$get_active_module_tws_output("table"), data.frame())
app_driver$expect_validation_error()
testthat::expect_equal(
Expand All @@ -131,7 +134,7 @@ testthat::test_that("e2e - tm_a_gee: Change in arm_var changes the table and doe
app_driver <- app_driver_tm_a_gee()

table_before <- app_driver$get_active_module_tws_output("table")
app_driver$set_active_module_input("arm_var-dataset_ADSL_singleextract-select", "ARMCD")
app_driver$set_active_module_input(ns_des_input("arm_var", "ADSL", "select"), "ARMCD")
testthat::expect_false(identical(table_before, app_driver$get_active_module_tws_output("table")))
app_driver$expect_no_validation_error()
app_driver$stop()
Expand All @@ -140,7 +143,7 @@ testthat::test_that("e2e - tm_a_gee: Change in arm_var changes the table and doe
testthat::test_that("e2e - tm_a_gee: Deselection of arm_var throws validation error.", {
skip_if_too_deep(5)
app_driver <- app_driver_tm_a_gee()
app_driver$set_active_module_input("arm_var-dataset_ADSL_singleextract-select", character(0))
app_driver$set_active_module_input(ns_des_input("arm_var", "ADSL", "select"), character(0))
testthat::expect_identical(app_driver$get_active_module_tws_output("table"), data.frame())
app_driver$expect_validation_error()
testthat::expect_equal(
Expand All @@ -150,21 +153,24 @@ testthat::test_that("e2e - tm_a_gee: Deselection of arm_var throws validation er
app_driver$stop()
})


testthat::test_that("e2e - tm_a_gee: Selection of visit_var changes the table and does not throw validation errors.", {
skip_if_too_deep(5)
app_driver <- app_driver_tm_a_gee()
table_before <- app_driver$get_active_module_tws_output("table")
app_driver$set_active_module_input("visit_var-dataset_ADQS_singleextract-select", "AVISITN")
testthat::expect_false(identical(table_before, app_driver$get_active_module_tws_output("table")))
app_driver$expect_no_validation_error()
app_driver$stop()
})
testthat::test_that(
"e2e - tm_a_gee: Selection of visit_var does not change the table and does not throw validation errors.",
{
skip_if_too_deep(5)
app_driver <- app_driver_tm_a_gee()
table_before <- app_driver$get_active_module_tws_output("table")
app_driver$set_active_module_input(ns_des_input("visit_var", "ADQS", "select"), "AVISITN")
testthat::expect_true(identical(table_before, app_driver$get_active_module_tws_output("table")))
app_driver$expect_no_validation_error()
app_driver$stop()
}
)

testthat::test_that("e2e - tm_a_gee: Deselection of visit_var throws validation error.", {
skip_if_too_deep(5)
app_driver <- app_driver_tm_a_gee()
app_driver$set_active_module_input("visit_var-dataset_ADQS_singleextract-select", character(0))
app_driver$set_active_module_input(ns_des_input("visit_var", "ADQS", "select"), character(0))
app_driver$wait_for_idle()
testthat::expect_identical(app_driver$get_active_module_tws_output("table"), data.frame())
app_driver$expect_validation_error()
testthat::expect_equal(
Expand All @@ -178,7 +184,7 @@ testthat::test_that("e2e - tm_a_gee: Selection of paramcd changes the table and
skip_if_too_deep(5)
app_driver <- app_driver_tm_a_gee()
table_before <- app_driver$get_active_module_tws_output("table")
app_driver$set_active_module_input("paramcd-dataset_ADQS_singleextract-filter1-vals", "BFIALL")
app_driver$set_active_module_input(ns_des_input("paramcd", "ADQS", "filter1-vals"), "BFIALL")
testthat::expect_false(identical(table_before, app_driver$get_active_module_tws_output("table")))
app_driver$expect_no_validation_error()
app_driver$stop()
Expand All @@ -187,7 +193,7 @@ testthat::test_that("e2e - tm_a_gee: Selection of paramcd changes the table and
testthat::test_that("e2e - tm_a_gee: Deselection of paramcd throws validation error.", {
skip_if_too_deep(5)
app_driver <- app_driver_tm_a_gee()
app_driver$set_active_module_input("paramcd-dataset_ADQS_singleextract-filter1-vals", character(0))
app_driver$set_active_module_input(ns_des_input("paramcd", "ADQS", "filter1-vals"), character(0))
testthat::expect_identical(app_driver$get_active_module_tws_output("table"), data.frame())
app_driver$expect_validation_error()
testthat::expect_equal(
Expand All @@ -207,19 +213,6 @@ testthat::test_that("e2e - tm_a_gee: Selection of cov_var changes the table and
app_driver$stop()
})

testthat::test_that("e2e - tm_a_gee: Deselection of cov_var throws validation error.", {
skip_if_too_deep(5)
app_driver <- app_driver_tm_a_gee()
app_driver$set_active_module_input("cov_var-dataset_ADQS_singleextract-select", character(0))
testthat::expect_identical(app_driver$get_active_module_tws_output("table"), data.frame())
app_driver$expect_validation_error()
testthat::expect_equal(
app_driver$active_module_element_text("cov_var-dataset_ADQS_singleextract-select_input > div > span"),
"An endpoint is required"
)
app_driver$stop()
})

testthat::test_that("e2e - tm_a_gee: Selection of conf_level changes the table and does not throw validation errors.", {
skip_if_too_deep(5)
app_driver <- app_driver_tm_a_gee()
Expand Down Expand Up @@ -257,7 +250,6 @@ testthat::test_that("e2e - tm_a_gee: Deselection of conf_level throws validation
app_driver$stop()
})


testthat::test_that("e2e - tm_a_gee: Selection of cor_struct changes the table and does not throw validation errors.", {
skip_if_too_deep(5)
app_driver <- app_driver_tm_a_gee()
Expand All @@ -268,21 +260,14 @@ testthat::test_that("e2e - tm_a_gee: Selection of cor_struct changes the table a
app_driver$stop()
})

testthat::test_that("e2e - tm_a_gee: Deselection of cor_struct throws validation error.", {
testthat::test_that("e2e - tm_a_gee: Deselection of cor_struct does not throw validation error.", {
skip_if_too_deep(5)
app_driver <- app_driver_tm_a_gee()
app_driver$set_active_module_input("cor_struct", character(0))
testthat::expect_identical(app_driver$get_active_module_tws_output("table"), data.frame())
# TO BE FIXED - there is no error displayed
app_driver$expect_validation_error()
testthat::expect_equal(
app_driver$active_module_element_text("cov_struct_input > div > span"),
"Please choose a correlation structure"
)
app_driver$set_active_module_input("cor_struct", character(0)) # shows enourmous warning message
app_driver$expect_no_validation_error()
app_driver$stop()
})


testthat::test_that("e2e - tm_a_gee: Selection of output_table changes the table and doesn't throw validation error.", {
skip_if_too_deep(5)
app_driver <- app_driver_tm_a_gee()
Expand Down
Loading