Wave 1 - tm_a_gee shinytests

[vedhav]

Part of #1108

[github-actions]

Unit Tests Summary

  1 files  ±0   38 suites  ±0   11m 4s ⏱️ -56s
332 tests  - 1  222 ✅ +3  110 💤 ±0  0 ❌  - 4 
602 runs   - 5  380 ✅ +3  222 💤 ±0  0 ❌  - 8 

Results for commit bd3e004. ± Comparison against base commit 8917d04.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
shinytest2-tm_a_gee	👶		$+147.48$	$+48$	$0$	$0$	$0$
shinytest2-tm_g_barchart_simple	👶		$+231.52$	$+73$	$0$	$0$	$0$
shinytest2-tm_g_ci	👶		$+104.93$	$+41$	$0$	$0$	$0$
shinytest2-tm_g_forest_rsp	👶		$+175.77$	$+48$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
shinytest2-tm_a_gee	👶		$+7.83$	e2e_tm_a_gee_Change_in_arm_var_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee	👶		$+7.39$	e2e_tm_a_gee_Deselection_of_arm_var_throws_validation_error.
shinytest2-tm_a_gee	👶		$+7.08$	e2e_tm_a_gee_Deselection_of_conf_level_throws_validation_error.
shinytest2-tm_a_gee	👶		$+26.91$	e2e_tm_a_gee_Deselection_of_cor_struct_does_not_throw_validation_error.
shinytest2-tm_a_gee	👶		$+7.05$	e2e_tm_a_gee_Deselection_of_id_var_throws_validation_error.
shinytest2-tm_a_gee	👶		$+7.31$	e2e_tm_a_gee_Deselection_of_paramcd_throws_validation_error.
shinytest2-tm_a_gee	👶		$+7.69$	e2e_tm_a_gee_Deselection_of_visit_var_throws_validation_error.
shinytest2-tm_a_gee	👶		$+7.46$	e2e_tm_a_gee_Module_initializes_in_teal_without_errors_and_produces_table_output.
shinytest2-tm_a_gee	👶		$+7.48$	e2e_tm_a_gee_Selection_of_conf_level_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee	👶		$+7.05$	e2e_tm_a_gee_Selection_of_conf_level_out_of_0_1_range_throws_validation_error.
shinytest2-tm_a_gee	👶		$+7.77$	e2e_tm_a_gee_Selection_of_cor_struct_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee	👶		$+7.87$	e2e_tm_a_gee_Selection_of_cov_var_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee	👶		$+7.89$	e2e_tm_a_gee_Selection_of_id_var_does_not_change_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee	👶		$+7.70$	e2e_tm_a_gee_Selection_of_output_table_changes_the_table_and_doesn_t_throw_validation_error.
shinytest2-tm_a_gee	👶		$+7.74$	e2e_tm_a_gee_Selection_of_paramcd_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee	👶		$+7.91$	e2e_tm_a_gee_Selection_of_visit_var_does_not_change_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee	👶		$+7.35$	e2e_tm_a_gee_Starts_with_specified_label_id_var_arm_var_visit_var_paramcd_cov_var_conf_level_and_conf_struct.
shinytest2-tm_g_barchart_simple	👶		$+9.66$	e2e_tm_g_barchart_simple_Changing_barlayout_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple	👶		$+9.87$	e2e_tm_g_barchart_simple_Changing_expand_y_range_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple	👶		$+10.00$	e2e_tm_g_barchart_simple_Changing_facet_scale_x_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple	👶		$+9.88$	e2e_tm_g_barchart_simple_Changing_facet_scale_y_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple	👶		$+9.86$	e2e_tm_g_barchart_simple_Changing_flip_axis_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple	👶		$+10.39$	e2e_tm_g_barchart_simple_Changing_label_bars_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple	👶		$+13.16$	e2e_tm_g_barchart_simple_Changing_rotate_bar_labels_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple	👶		$+10.14$	e2e_tm_g_barchart_simple_Changing_rotate_x_label_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple	👶		$+9.84$	e2e_tm_g_barchart_simple_Changing_rotate_y_label_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple	👶		$+9.91$	e2e_tm_g_barchart_simple_Changing_show_n_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple	👶		$+10.11$	e2e_tm_g_barchart_simple_De_selection_of_fill_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple	👶		$+9.52$	e2e_tm_g_barchart_simple_De_selection_of_x_facet_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple	👶		$+9.59$	e2e_tm_g_barchart_simple_De_selection_of_y_facet_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple	👶		$+7.96$	e2e_tm_g_barchart_simple_Deselection_of_x_throws_validation_error.
shinytest2-tm_g_barchart_simple	👶		$+9.29$	e2e_tm_g_barchart_simple_Duplicate_between_x_and_fill_selection_throws_validation_error
shinytest2-tm_g_barchart_simple	👶		$+9.90$	e2e_tm_g_barchart_simple_Duplicate_between_x_and_x_facet_selection_throws_validation_error
shinytest2-tm_g_barchart_simple	👶		$+10.37$	e2e_tm_g_barchart_simple_Duplicate_between_x_and_y_facet_selection_throws_validation_error
shinytest2-tm_g_barchart_simple	👶		$+7.49$	e2e_tm_g_barchart_simple_Module_initializes_in_teal_without_errors_and_produces_output.
shinytest2-tm_g_barchart_simple	👶		$+12.24$	e2e_tm_g_barchart_simple_Selection_of_fill_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple	👶		$+10.00$	e2e_tm_g_barchart_simple_Selection_of_x_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple	👶		$+11.77$	e2e_tm_g_barchart_simple_Selection_of_x_facet_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple	👶		$+11.96$	e2e_tm_g_barchart_simple_Selection_of_y_facet_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple	👶		$+8.60$	e2e_tm_g_barchart_simple_Starts_with_specified_label_id_var_arm_var_visit_var_paramcd_cov_var_conf_level_and_conf_struct.
shinytest2-tm_g_ci	👶		$+7.22$	e2e_tm_g_ci_Deselecting_AVISIT_filter_value_throws_validation_error.
shinytest2-tm_g_ci	👶		$+7.36$	e2e_tm_g_ci_Deselecting_PARAMCD_filter_value_throws_validation_error.
shinytest2-tm_g_ci	👶		$+7.69$	e2e_tm_g_ci_Deselecting_color_column_changes_plot_output_and_doesn_t_throw_validation_error.
shinytest2-tm_g_ci	👶		$+7.38$	e2e_tm_g_ci_Deselecting_x_var_column_throws_validation_error.
shinytest2-tm_g_ci	👶		$+7.21$	e2e_tm_g_ci_Deselecting_y_var_column_throws_validation_error.
shinytest2-tm_g_ci	👶		$+7.27$	e2e_tm_g_ci_Module_initializes_with_specified_label_x_var_y_var_ADLB_filters_color_conf_level_and_stat.
shinytest2-tm_g_ci	👶		$+7.66$	e2e_tm_g_ci_Selecting_AVISIT_filter_value_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci	👶		$+7.82$	e2e_tm_g_ci_Selecting_PARAMCD_filter_value_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci	👶		$+7.69$	e2e_tm_g_ci_Selecting_color_column_changes_plot_output_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci	👶		$+7.72$	e2e_tm_g_ci_Selecting_confidence_interval_value_changes_plot_and_doesn_t_throw_any_errors.
shinytest2-tm_g_ci	👶		$+7.66$	e2e_tm_g_ci_Selecting_statistic_to_use_changes_a_plot_and_doesn_t_throw_any_errors.
shinytest2-tm_g_ci	👶		$+8.04$	e2e_tm_g_ci_Selecting_x_var_column_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci	👶		$+7.64$	e2e_tm_g_ci_Selecting_y_var_column_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci	👶		$+6.57$	e2e_tm_g_ci_example_ci_module_initializes_in_teal_without_errors_and_produces_plot_output.
shinytest2-tm_g_forest_rsp	👶		$+10.15$	e2e_tm_g_forest_rsp_Changing_font_size_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶		$+10.12$	e2e_tm_g_forest_rsp_Changing_rel_width_forest_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶		$+8.78$	e2e_tm_g_forest_rsp_Deselecting_arm_var_throws_validation_error.
shinytest2-tm_g_forest_rsp	👶		$+9.55$	e2e_tm_g_forest_rsp_Deselecting_conf_level_or_selecting_outside_the_range_of_0_1_throws_validation_error.
shinytest2-tm_g_forest_rsp	👶		$+9.28$	e2e_tm_g_forest_rsp_Deselecting_paramcd_throws_validation_error.
shinytest2-tm_g_forest_rsp	👶		$+8.93$	e2e_tm_g_forest_rsp_Deselecting_responders_throws_validation_error.
shinytest2-tm_g_forest_rsp	👶		$+10.18$	e2e_tm_g_forest_rsp_Deselecting_strata_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶		$+9.98$	e2e_tm_g_forest_rsp_Deselecting_subgroup_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶		$+8.13$	e2e_tm_g_forest_rsp_Module_initializes_in_teal_without_errors_and_produces_plot_output.
shinytest2-tm_g_forest_rsp	👶		$+9.34$	e2e_tm_g_forest_rsp_Module_initializes_with_specified_label_arm_var_paramcd_aval_var_responders_subgroup_var_strata_var_conf_level_fixed_symbol_size_rel_width_forest_font_size.
shinytest2-tm_g_forest_rsp	👶		$+8.98$	e2e_tm_g_forest_rsp_Selecting_a_non_factors_column_in_subgroup_var_throws_validation_error.
shinytest2-tm_g_forest_rsp	👶		$+10.30$	e2e_tm_g_forest_rsp_Selecting_arm_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶		$+10.20$	e2e_tm_g_forest_rsp_Selecting_conf_level_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶		$+11.40$	e2e_tm_g_forest_rsp_Selecting_paramcd_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶		$+9.98$	e2e_tm_g_forest_rsp_Selecting_responders_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶		$+10.19$	e2e_tm_g_forest_rsp_Selecting_strata_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶		$+10.31$	e2e_tm_g_forest_rsp_Selecting_subgroup_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶		$+9.98$	e2e_tm_g_forest_rsp_Unsetting_fixed_symbol_size_changes_plot_and_doesn_t_throw_validation_errors.

Results for commit 8fe28a3

♻️ This comment has been updated with latest results.

[vedhav]

@m7pr looks like since we did not have the CI before we missed this. Some tests are failing, as we expect table to change but even with new encoding selection the table remains the same. Can you please check the tests and see if you can reproduce it?

[m7pr]

Sure, sorry!

[m7pr]

Hey @vedhav I fixed few tests. I blindly assumed change in some inputs will change the table but it actually does not change the table. Maybe it changes the table on the combination of multiple inputs, but single change keeps the table as it is. Maybe with @kartikeyakirar approach of mutliple parameter setup testing will undiscover the influence of the parameters that do not change the table on a single change. it's id_var and visit_var

[vedhav]

I think creating valid data to work for these tests should be enough. It could be just creating a new column in the ADSL with a new patient id column.

[m7pr]

superlintr is failing

[vedhav]

Okay, I think there is no way to influence this table with that one input because the table is dependent on the values in the ARM column. So, I think expecting the table to be same makes sense here.
This LGTM, but since I raised the PR I cannot approve. Feel free to merge this @m7pr