Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1108 {shinytest2} feature branch #1126

Merged
merged 62 commits into from
May 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
c81fee9
remove dynamic_assertions
m7pr Feb 8, 2024
a62b153
git merge
m7pr Feb 9, 2024
0b5b408
Merge branch 'main' of https://github.com/insightsengineering/teal.mo…
m7pr Feb 15, 2024
ad6a8bb
Merge branch 'main' of https://github.com/insightsengineering/teal.mo…
m7pr Feb 16, 2024
ca06efc
Merge branch 'main' of https://github.com/insightsengineering/teal.mo…
m7pr Feb 19, 2024
4280dcb
Merge branch 'main' of https://github.com/insightsengineering/teal.mo…
m7pr Apr 22, 2024
791c240
create feature branch for all PRs for other modules
m7pr Apr 22, 2024
b546594
[skip actions] Bump version to 0.9.0.9022
m7pr Apr 22, 2024
ab3469a
Merge branch 'main' into shinytest2@main
averissimo Apr 24, 2024
5aa1fdd
Wave 1 - `tm_g_forest_rsp` shinytests (#1129)
vedhav Apr 25, 2024
58cc42c
[skip actions] Bump version to 0.9.0.9023
vedhav Apr 25, 2024
32c6045
fix: add testing depth and missing dependency
averissimo Apr 25, 2024
6f4a700
Wave 1 - `tm_g_barchart_simple` shinytest2 (#1134)
averissimo Apr 25, 2024
8917d04
Wave 1 - `tm_g_ci` shinytests (#1125)
gogonzo Apr 25, 2024
87f9c98
Wave 1 - `test_table_changes_no_errors` and `test_plot_changes_no_err…
m7pr Apr 26, 2024
b9ce19f
[skip actions] Bump version to 0.9.0.9024
m7pr Apr 26, 2024
745092b
Wave 1 - `tm_a_gee` shinytests (#1139)
vedhav Apr 26, 2024
2843db5
Wave 2 - `tm_g_ipp` shinytests (#1141)
vedhav Apr 29, 2024
b6e8df7
[skip actions] Bump version to 0.9.0.9024
vedhav Apr 29, 2024
0a3192b
Merge remote-tracking branch 'origin/main' into shinytest2@main
gogonzo Apr 30, 2024
3d2f674
[skip actions] Bump version to 0.9.1.9001
gogonzo Apr 30, 2024
8587368
Wave 2 - `tm_g_km` shinytests (#1133)
m7pr Apr 30, 2024
aad3af7
Wave 2 - `tm_g_lineplot` shinytest2 (#1137)
kartikeyakirar May 1, 2024
e7f0852
[skip actions] Bump version to 0.9.1.9001
kartikeyakirar May 1, 2024
ac0ded9
Wave 2 - `tm_g_forest_tte` shinytest2 (#1138)
averissimo May 2, 2024
7fdcb1b
[skip actions] Bump version to 0.9.1.9001
gogonzo May 2, 2024
f428e7b
fix: remove `formatters` and `tidyr` from the verdepcheck config
vedhav May 3, 2024
feda87e
[skip actions] Bump version to 0.9.1.9001
vedhav May 3, 2024
e5e3f0f
Wave 7 - `tm_t_tte` shinytests (#1174)
vedhav May 7, 2024
064e60e
Wave 7 - `tm_t_summary_by` shinytests (#1173)
vedhav May 7, 2024
101d85b
Wave 7 - `tm_t_summary` shinytests (#1172)
vedhav May 7, 2024
9aa73f8
Wave 7 - `tm_t_smq` shinytests (#1171)
vedhav May 7, 2024
39c8ceb
Wave 7 - `tm_t_shift_by_grade` shinytests (#1170)
vedhav May 7, 2024
3beb632
Wave 7 - `tm_t_shift_by_arm_by_worst` shinytests (#1169)
vedhav May 7, 2024
de1a50c
[skip actions] Bump version to 0.9.1.9001
kartikeyakirar May 7, 2024
6b23245
Wave 3 - `tm_g_pp_vitals` shinytest2 (#1143)
vedhav May 7, 2024
06faf22
Wave 3 - `tm_t_abnormality` shinytest2 (#1144)
vedhav May 7, 2024
d285a0f
Wave 1 - `tm_a_mmrm` shinytests (#1131)
kartikeyakirar May 7, 2024
4492a92
Wave 6 - `tm_t_pp_basic_info` shinytests (#1164)
vedhav May 7, 2024
c158cd6
Wave 6 - `tm_t_pp_laboratory` shinytests (#1165)
vedhav May 7, 2024
da7584a
Wave 6 - `tm_t_pp_medical_history` shinytests (#1166)
vedhav May 7, 2024
bd0d80a
Wave 6 - `tm_t_pp_prior_medication` shinytests (#1167)
vedhav May 7, 2024
53115ab
Wave 6 - `tm_t_shift_by_arm` shinytests (#1168)
vedhav May 7, 2024
8e60fb3
Wave 3 - `tm_g_pp_patient_timeline` shinytest2 (#1146)
m7pr May 7, 2024
a967457
Wave 5 - `tm_t_events_patyear` shinytests (#1159)
vedhav May 7, 2024
7c1a8f6
Wave 5 - `tm_t_events_summary` shinytests (#1160)
vedhav May 7, 2024
b96db11
Wave 5 - `tm_t_logistic` shinytests (#1162)
vedhav May 7, 2024
5754243
Wave 5 - `tm_t_mult_events` shinytests (#1163)
vedhav May 7, 2024
dec314f
Wave 4 - `tm_t_ancova` shinytests (#1154)
vedhav May 7, 2024
ef0f711
Wave 4 - `tm_t_binary_outcome` shinytests (#1155)
vedhav May 7, 2024
7b26f00
Wave 4 - `tm_t_coxreg` shinytests (#1156)
vedhav May 7, 2024
e3b603a
Wave 4 - `tm_t_events` shinytests (#1157)
vedhav May 7, 2024
5e7d4ff
Wave 4 - `tm_t_events_by_grade` shinytests (#1158)
vedhav May 7, 2024
76d3e0d
Wave2 - `tm_g_pp_adverse_events` shinytests (#1150)
gogonzo May 7, 2024
c25321e
Wave 3 - `tm_t_abnormality_by_worst_grade` shinytest2 (#1145)
vedhav May 7, 2024
72fc9a2
Wave 3 - `tm_g_pp_therapy` shinytest2 (#1148)
averissimo May 7, 2024
2c711af
merge back from main.
kartikeyakirar May 7, 2024
37b7a71
Merge branch 'main' into shinytest2@main
vedhav May 9, 2024
d481686
[skip actions] Bump version to 0.9.1.9003
vedhav May 9, 2024
0d5ed4a
Wave 5 - `tm_t_exposure` shinytests (#1161)
vedhav May 9, 2024
2477b02
Update .github/workflows/check.yaml
vedhav May 10, 2024
e8dc8b4
Post cleanup shinytest2 (#1184)
kartikeyakirar May 10, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
with:
additional-env-vars: |
_R_CHECK_CRAN_INCOMING_REMOTE_=false
TESTING_DEPTH=5
additional-r-cmd-check-params: --as-cran
enforce-note-blocklist: true
note-blocklist: |
Expand Down
11 changes: 6 additions & 5 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: teal.modules.clinical
Title: 'teal' Modules for Standard Clinical Outputs
Version: 0.9.1.9003
Date: 2024-05-08
Date: 2024-05-09
Authors@R: c(
person("Joe", "Zhu", , "[email protected]", role = c("aut", "cre")),
person("Jana", "Stoilova", , "[email protected]", role = "aut"),
Expand Down Expand Up @@ -71,6 +71,7 @@ Suggests:
lubridate (>= 1.7.9),
nestcolor (>= 0.1.0),
pkgload,
rvest,
shinytest2,
styler,
testthat (>= 3.1.5),
Expand All @@ -80,16 +81,16 @@ VignetteBuilder:
Config/Needs/verdepcheck: insightsengineering/teal,
insightsengineering/teal.transform, insightsengineering/tern,
tidymodels/broom, mllg/checkmate, tidyverse/dplyr, rstudio/DT,
insightsengineering/formatters, tidyverse/ggplot2, slowkow/ggrepel,
r-lib/lifecycle, daroczig/logger, insightsengineering/rlistings,
tidyverse/ggplot2, slowkow/ggrepel, r-lib/lifecycle,
daroczig/logger, insightsengineering/rlistings,
rstudio/rmarkdown, insightsengineering/rtables, r-lib/scales,
rstudio/shiny, daattali/shinyjs, rstudio/shinyvalidate,
dreamRs/shinyWidgets, insightsengineering/teal.code,
insightsengineering/teal.data, insightsengineering/teal.logger,
insightsengineering/teal.reporter, insightsengineering/teal.widgets,
insightsengineering/tern.gee, insightsengineering/tern.mmrm,
tidyverse/tidyr, shosaco/vistime, tidyverse/forcats, yihui/knitr,
tidyverse/lubridate, insightsengineering/nestcolor, r-lib/pkgload,
shosaco/vistime, tidyverse/forcats, yihui/knitr, tidyverse/lubridate,
insightsengineering/nestcolor, r-lib/pkgload, tidyverse/rvest,
rstudio/shinytest2, r-lib/styler, r-lib/testthat, r-lib/withr
Config/Needs/website: insightsengineering/nesttemplate
Config/testthat/edition: 3
Expand Down
2 changes: 1 addition & 1 deletion R/tm_a_gee.R
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@ srv_gee <- function(id,

iv_r <- reactive({
iv <- shinyvalidate::InputValidator$new()
iv$add_rule("conf_level", shinyvalidate::sv_required("Please choose a confidence level."))
iv$add_rule("conf_level", shinyvalidate::sv_required("Please choose a confidence level"))
iv$add_rule(
"conf_level",
shinyvalidate::sv_between(
Expand Down
5 changes: 2 additions & 3 deletions R/tm_g_pp_therapy.R
Original file line number Diff line number Diff line change
Expand Up @@ -65,15 +65,14 @@ template_therapy <- function(dataname = "ANL",

dataname[setdiff(cols_to_include, names(dataname))] <- NA

therapy_table <-
dataname %>%
therapy_table <- dataname %>%
dplyr::filter(atirel %in% c("CONCOMITANT", "PRIOR")) %>% # removed PRIOR_CONCOMITANT
dplyr::select(dplyr::all_of(cols_to_include)) %>%
dplyr::filter(!is.na(cmdecod)) %>%
dplyr::mutate(Dosage = paste(cmdose, cmdosu, cmdosfrq, cmroute)) %>%
dplyr::select(-cmdose, -cmdosu, -cmdosfrq, -cmroute) %>%
dplyr::select(cmindc, cmdecod, Dosage, dplyr::everything()) %>%
dplyr::mutate(CMDECOD = dplyr::case_when(
dplyr::mutate(!!cmdecod_char := dplyr::case_when(
nchar(as.character(cmdecod)) > 20 ~ as.character(cmtrt),
TRUE ~ as.character(cmdecod)
)) %>%
Expand Down
4 changes: 4 additions & 0 deletions tests/testthat/helper-TealAppDriver.R
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,7 @@ init_teal_app_driver <- function(...) {
.package = "teal"
)
}

ns_des_input <- function(id, dataname, type) {
sprintf("%s-dataset_%s_singleextract-%s", id, dataname, type)
}
Loading
Loading