1108 {shinytest2} feature branch
#1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'main' of https://github.com/insightsengineering/teal.modules.clinical # Conflicts: # R/dynamic_assertions.R # man/dyn_assertion.Rd
kartikeyakirar
previously requested changes
Apr 22, 2024
Signed-off-by: André Veríssimo <[email protected]>
|
Is there a reason not to add I didn't do this on my previous PR, but it may live here |
Unit Tests Summary 1 files 70 suites 58m 35s ⏱️ Results for commit e8dc8b4. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 0428dd8 ♻️ This comment has been updated with latest results. |
# Pull Request Part of #1108 ### What is being tested - Default values that can be changed - Selecting `x` variable - Deselecting `x` variable should give error - Deselecting others does not throw error - Selecting same variables as `x` has a validation error --------- Signed-off-by: André Veríssimo <[email protected]> Co-authored-by: kartikeya kirar <[email protected]>
…ors` (#1135) Helper functions to test whether plot or table were changed, based on a value change in specific input. --------- Signed-off-by: Marcin <[email protected]> Signed-off-by: André Veríssimo <[email protected]> Co-authored-by: André Veríssimo <[email protected]> Co-authored-by: Vedha Viyash <[email protected]> Co-authored-by: kartikeya kirar <[email protected]> Co-authored-by: Dawid Kałędkowski <[email protected]>
Part of #1108 --------- Signed-off-by: Marcin <[email protected]> Co-authored-by: m7pr <[email protected]> Co-authored-by: Marcin <[email protected]> Co-authored-by: kartikeya kirar <[email protected]>
Part of #1108 --------- Co-authored-by: unknown <[email protected]>
Part of #1108 --------- Signed-off-by: Vedha Viyash <[email protected]> Co-authored-by: unknown <[email protected]>
Part of #1108 --------- Co-authored-by: unknown <[email protected]>
Part of #1108 --------- Co-authored-by: unknown <[email protected]>
Part of #1108 --------- Co-authored-by: unknown <[email protected]>
Part of #1108 --------- Co-authored-by: unknown <[email protected]>
Part of #1108 --------- Co-authored-by: unknown <[email protected]>
Part of #1108 --------- Co-authored-by: unknown <[email protected]>
Part of #1108 --------- Co-authored-by: unknown <[email protected]>
linksto #1108 --------- Signed-off-by: kartikeya kirar <[email protected]> Co-authored-by: vedhav <[email protected]> Co-authored-by: kartikeya kirar <[email protected]> Co-authored-by: Vedha Viyash <[email protected]>
# Pull Request Part of #1108 Module has very specific set of variables that don't allow for many choices Fields not 100% tested: - `cmdecod`: selected variable needs to be named CMDECOD due to limitation in module's logic - `cmtrt`: Could not manipulate data for this field to have any change on output. - It seems that it is only used when CMDECOD has long values --------- Co-authored-by: Vedha Viyash <[email protected]> Co-authored-by: vedhav <[email protected]>
Merge branch 'main' into shinytest2@main # Conflicts: # DESCRIPTION
Part of #1108 --------- Signed-off-by: Vedha Viyash <[email protected]> Signed-off-by: kartikeya kirar <[email protected]> Co-authored-by: unknown <[email protected]>
vedhav
reviewed
May 9, 2024
cicdguy
reviewed
May 9, 2024
Signed-off-by: Vedha Viyash <[email protected]>
- [x] Rename `get_active_module_pws_output` with `get_active_module_plot_output` respectively after insightsengineering/teal#1210 is merged. @kartikeyakirar - [x] Rename `get_active_module_tws_output` with `get_active_module_table_output` @vedhav - [x] Replace `rvest::html_table()` and use `get_active_module_table_output` for DT tables. @kartikeyakirar - [x] Check if all the tests have skip_if_too_deep(5) and app_driver$stop() @kartikeyakirar - [x] Make sure the test description is standard: Begin with a Capital letter and end with . uses variables like arm_var instead of arm_var-variable or ARM variable @vedhav - [x] Verify that all the module params are covered in the test. Especially check for cases with fixed data transform. (leave parameter with deprecated status) @kartikeyakirar - [x] prefix teal.data:: for teal_data(), datanames() and join_keys where ever its missing. @kartikeyakirar
vedhav
dismissed
kartikeyakirar’s stale review
unblocked as we merged all the branches to this feature branch
vedhav
approved these changes
May 10, 2024
teal.modules.clinical
✔ | F W S OK | Context
✔ | 147 | examples [236.5s]
✔ | 4 | facet_grid_formula
✔ | 48 | shinytest2-tm_a_gee [158.7s]
✔ | 309 | shinytest2-tm_a_mmrm [619.1s]
✔ | 73 | shinytest2-tm_g_barchart_simple [191.1s]
✔ | 41 | shinytest2-tm_g_ci [88.4s]
✔ | 48 | shinytest2-tm_g_forest_rsp [149.6s]
✔ | 26 | shinytest2-tm_g_forest_tte [52.5s]
✔ | 45 | shinytest2-tm_g_ipp [88.2s]
✔ | 80 | shinytest2-tm_g_km [198.6s]
✔ | 39 | shinytest2-tm_g_lineplot [70.9s]
✔ | 48 | shinytest2-tm_g_pp_adverse_events [108.4s]
✔ | 74 | shinytest2-tm_g_pp_patient_timeline [185.3s]
✔ | 59 | shinytest2-tm_g_pp_therapy [152.6s]
✔ | 34 | shinytest2-tm_g_pp_vitals [71.6s]
✔ | 27 | shinytest2-tm_t_abnormality [55.0s]
✔ | 27 | shinytest2-tm_t_abnormality_by_worst_grade [53.9s]
✔ | 39 | shinytest2-tm_t_ancova [77.0s]
✔ | 38 | shinytest2-tm_t_binary_outcome [59.7s]
✔ | 32 | shinytest2-tm_t_coxreg [56.7s]
✔ | 25 | shinytest2-tm_t_events [47.0s]
✔ | 31 | shinytest2-tm_t_events_by_grade [91.9s]
✔ | 22 | shinytest2-tm_t_events_patyear [42.9s]
✔ | 8 24 | shinytest2-tm_t_events_summary [85.4s]
✔ | 29 | shinytest2-tm_t_exposure [91.5s]
✔ | 27 | shinytest2-tm_t_logistic [72.0s]
✔ | 20 | shinytest2-tm_t_mult_events [71.7s]
✔ | 16 | shinytest2-tm_t_pp_basic_info [46.0s]
✔ | 47 | shinytest2-tm_t_pp_laboratory [132.9s]
✔ | 28 | shinytest2-tm_t_pp_medical_history [83.2s]
✔ | 29 | shinytest2-tm_t_pp_prior_medication [99.1s]
✔ | 25 | shinytest2-tm_t_shift_by_arm [70.4s]
✔ | 37 | shinytest2-tm_t_shift_by_arm_by_worst [118.6s]
✔ | 28 | shinytest2-tm_t_shift_by_grade [109.0s]
✔ | 25 | shinytest2-tm_t_smq [61.7s]
✔ | 18 | shinytest2-tm_t_summary [29.6s]
✔ | 33 | shinytest2-tm_t_summary_by [63.0s]
✔ | 32 | shinytest2-tm_t_tte [50.7s]
✔ | 1 | string_ops
✔ | 9 | substitute_names
✔ | 8 | tm_a_gee
✔ | 10 | tm_a_mmrm
✔ | 8 | tm_g_ci
✔ | 2 | tm_g_forest_rsp
✔ | 2 | tm_g_forest_tte
✔ | 4 | tm_g_ipp
✔ | 6 | tm_g_km
✔ | 4 | tm_g_lineplot
✔ | 6 | tm_t_abnormality
✔ | 5 | tm_t_abnormality_by_worst_grade
✔ | 14 | tm_t_ancova
✔ | 16 | tm_t_binary_outcome
✔ | 6 | tm_t_coxreg
✔ | 12 | tm_t_events
✔ | 16 | tm_t_events_by_grade
✔ | 6 | tm_t_events_patyear
✔ | 4 | tm_t_events_summary
✔ | 6 | tm_t_exposure
✔ | 6 | tm_t_logisitic
✔ | 12 | tm_t_mult_events
✔ | 9 | tm_t_pp_medical_history
✔ | 6 | tm_t_shift_by_arm
✔ | 6 | tm_t_shift_by_arm_by_worst
✔ | 6 | tm_t_shift_by_grade
✔ | 4 | tm_t_smq
✔ | 10 | tm_t_summary
✔ | 10 | tm_t_summary_by
✔ | 8 | tm_t_tte
✔ | 50 | utils
✔ | 6 | validate_standard_inputs
══ Results ═══════════════════════════════════════════════════════════════════════════════════════════════════════════════════════
Duration: 4044.2 s
[ FAIL 0 | WARN 8 | SKIP 0 | PASS 2012 ] |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1108
A unified branch for all partial PRs that will solve #1108
Merge at the end. Place where we can unify PRs