Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NULL paramcd value in tm_t_summary_by #1083

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

edelarua
Copy link
Contributor

Pull Request

Fixes #1082

Required version of teal.data should be updated after merging insightsengineering/teal.data#301.

@edelarua edelarua added the sme label Feb 27, 2024
Copy link
Contributor

github-actions bot commented Feb 27, 2024

Unit Tests Summary

  1 files   33 suites   2s ⏱️
150 tests 150 ✅   0 💤 0 ❌
282 runs  170 ✅ 112 💤 0 ❌

Results for commit a34ce30.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@pawelru pawelru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting that there will be more changes required to support this but actually this is already there.
LGTM 👍

@pawelru
Copy link
Contributor

pawelru commented Feb 27, 2024

All is ready to go. Please allow me to merge it

@pawelru pawelru merged commit 14b71af into main Feb 27, 2024
24 checks passed
@pawelru pawelru deleted the 1082_fix_paramcd_null@main branch February 27, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tm_t_summary_by - nullable paramcd
2 participants