Skip to content

Commit

Permalink
Allow NULL paramcd value in tm_t_summary_by (#1083)
Browse files Browse the repository at this point in the history
# Pull Request

<!--- Replace `#nnn` with your issue link for reference. -->

Fixes #1082

Required version of `teal.data` should be updated after merging
insightsengineering/teal.data#301.

Co-authored-by: Pawel Rucki <[email protected]>
  • Loading branch information
edelarua and pawelru authored Feb 27, 2024
1 parent 8e53ef0 commit 14b71af
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
### Enhancements
* Updated `tm_g_forest_rsp` and `tm_g_forest_tte` to use refactored version of `g_forest`. Plots are now displayed as `ggplot` objects instead of `grob` objects. Added parameters `font_size` and `rel_width_forest` to control font size and width of plot relative to table, respectively.

### Enhancements
* Updated `tm_t_summary_by` to allow `NULL` input to `paramcd` argument.

### Miscellaneous
* Removed `formatters` from dependencies and replaced the use of its functions relating to variable labels with functions from `teal.data`.

Expand Down
2 changes: 1 addition & 1 deletion R/tm_t_summary_by.R
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ tm_t_summary_by <- function(label,
checkmate::assert_class(by_vars, "choices_selected")
checkmate::assert_class(summarize_vars, "choices_selected")
checkmate::assert_class(id_var, "choices_selected")
checkmate::assert_class(paramcd, "choices_selected")
checkmate::assert_class(paramcd, "choices_selected", null.ok = TRUE)
checkmate::assert_class(denominator, "choices_selected")
checkmate::assert_flag(add_total)
checkmate::assert_string(total_label)
Expand Down

0 comments on commit 14b71af

Please sign in to comment.