-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return ls(@env) if @datanames not specified #330
Conversation
Code Coverage Summary
Diff against main
Results for commit: efcd0d1 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 14 suites 2s ⏱️ Results for commit efcd0d1. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceAdditional test case details
Results for commit ab31046 ♻️ This comment has been updated with latest results. |
I was wondering the other day what is the actual point of |
Not needed |
teal.data::datanames()
should returnls(@env)
if is not specified. IMOdatanames<-
function shouldn't be supported and determining module's datanames should be done throughmodule$datanames
only.teal.data::datanames
has been created only for teal-app to limit datanames. Forteal.data
package it doesn't have any usage at all and should be deprecated in the future. I think that we should usels(get_env(<teal_data>))
instead in teal.