Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datanames slot in teal_transform (enhanced teal.data::datanames()) #1335

Closed
wants to merge 1 commit into from

Conversation

gogonzo
Copy link
Contributor

@gogonzo gogonzo commented Aug 30, 2024

Done for insightsengineering/teal.data#330 where I enhanced teal.data::datanames() function to return ls(data@env) when @datanames is not specified. In the long term I suggest @datanames field to be discontinued.

@gogonzo gogonzo added the core label Aug 30, 2024
@gogonzo gogonzo changed the title another datanames slot in teal_transform (enhanced teal.data::datanames()) Aug 30, 2024
@m7pr
Copy link
Contributor

m7pr commented Aug 30, 2024

@gogonzo I agree that maintaining teal_data@datanames, modules$datanames and ls(get_env(teal_data)) became problematic and it's confusing on how many ways are there of specyfing this. If we can get rid of teal_data@datanames and stick to ls(get_env(teal_data)) then at least it brings some clarity to the ecosystem. We could go even one step further and rename teal.data::datanames() to teal.data::ls_env() as it's gonna be even more clear

@gogonzo
Copy link
Contributor Author

gogonzo commented Sep 2, 2024

Closing this PR in favour of #1334

@gogonzo gogonzo closed this Sep 2, 2024
@gogonzo gogonzo deleted the 1298_teal_datanames@main branch September 2, 2024 06:32
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants