Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cdisc_data information into join_keys #120

Closed
nikolas-burkoff opened this issue Nov 23, 2022 · 0 comments · Fixed by #132
Closed

Add cdisc_data information into join_keys #120

nikolas-burkoff opened this issue Nov 23, 2022 · 0 comments · Fixed by #132
Assignees
@mhallal1
Labels
core
Milestone
Refactor join keys

Comments

@nikolas-burkoff
Copy link
Contributor

nikolas-burkoff commented Nov 23, 2022 •
edited
Loading

Related to #78 and may want to be done at the same time.

In order for tdata objects to be the universal data object in teal we need the cdisc information (i.e. parents) to be added into join_keys so that the information can be passed through to the filter panel.

This issue is to:

  1. Update join_keys class to allow parents to be included (should this be cdisc_join_keys)?
  2. Update CDISCData$new/mutate to add the parents information into join_keys

If once done this task it looks like we can remove CDISCTealData and just use TealData with cdisc_join_keys inside it then create an issue to do this and make changes downstream in teal and teal.slice.
@nikolas-burkoff nikolas-burkoff mentioned this issue Nov 23, 2022
Closed
@gogonzo gogonzo added this to the Refactor join keys milestone Nov 24, 2022
@gogonzo gogonzo mentioned this issue Nov 29, 2022
Closed
This was referenced Jan 23, 2023
Merged
Merged
@mhallal1 mhallal1 self-assigned this Jan 25, 2023
mhallal1 added a commit that referenced this issue Feb 8, 2023
@mhallal1 @dependabot-preview
@arkadiuszbeer @asbates @gogonzo
add cdisc information into JoinKeys (#132)
36090d2 
closes #120 

- removed `CDISCTealData` and replaced its functionality with
`TealData`.
- removed `join_keys` mentions in `TealDataset` and
`TealDatasetConnector`.
- updated wrappers `cdisc_data` and `teal_data` to set up join_keys by
calling `JoinKeys` functionalities. They check if
`join_keys` are passed otherwise they create them according to primary
keys.
- deprecated `cdisc_data_file`
- Added tests to `test-joinKeys.R`
- Updated and added tests of `test-TealData`, `test-TealDataAbstract`,
`test-cdisc_data` and `test-teal_data`.
- updated `teal.slice::init_filtered_data` to remove `CDISCTealData` S3
method and to account for `cdisc` status in the `TealData` S3 method:
insightsengineering/teal.slice#169

---------

Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Arkadiusz Beer <[email protected]>
Co-authored-by: Andrew Bates <[email protected]>
Co-authored-by: Dawid Kałędkowski <[email protected]>
mhallal1 added a commit to insightsengineering/teal.slice that referenced this issue Feb 8, 2023
@mhallal1
update init_filtered_data (#169)
d35be75 
related to insightsengineering/teal.data#120

Updated `teal.slice::init_filtered_data` to remove `CDISCTealData` S3
method and to account for `cdisc` status in the `TealData` S3 method.

---------

Signed-off-by: Mahmoud Hallal <[email protected]>
Co-authored-by: Nikolas Burkoff <[email protected]>
This was referenced Apr 14, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhallal1 mhallal1

Labels
core
Projects
None yet
Milestone
Refactor join keys
Development

Successfully merging a pull request may close this issue.

add cdisc information into JoinKeys insightsengineering/teal.data
3 participants
@gogonzo @nikolas-burkoff @mhallal1