Skip to content

Commit

Permalink
add cdisc information into JoinKeys (#132)
Browse files Browse the repository at this point in the history
closes #120 

- removed `CDISCTealData` and replaced its functionality with
`TealData`.
- removed `join_keys` mentions in `TealDataset` and
`TealDatasetConnector`.
- updated wrappers `cdisc_data` and `teal_data` to set up join_keys by
calling `JoinKeys` functionalities. They check if
`join_keys` are passed otherwise they create them according to primary
keys.
- deprecated `cdisc_data_file`
- Added tests to `test-joinKeys.R`
- Updated and added tests of `test-TealData`, `test-TealDataAbstract`,
`test-cdisc_data` and `test-teal_data`.
- updated `teal.slice::init_filtered_data` to remove `CDISCTealData` S3
method and to account for `cdisc` status in the `TealData` S3 method:
insightsengineering/teal.slice#169

---------

Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Arkadiusz Beer <[email protected]>
Co-authored-by: Andrew Bates <[email protected]>
Co-authored-by: Dawid Kałędkowski <[email protected]>
  • Loading branch information
5 people authored Feb 8, 2023
1 parent cd2b284 commit 36090d2
Show file tree
Hide file tree
Showing 34 changed files with 2,073 additions and 2,655 deletions.
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
* Improved error message in `get_cdisc_keys`.
* Fixed help files for `TealDataset` and `MAETealDataset`.
* Added backstop for missing `reticulate` package in _teal.data with Python_ vignette.
* Removed `CDISCTealData` class and updated `TealData` to account for the removed functionality.
* Added datasets parents information to `JoinKeys` class.
* Updated `cdisc_data` and `teal_data` wrappers to handle join_keys creation and updating instead of `CDISCTealData` and `TealData`.
* Removed join_keys methods from `TealDataset`, `TealDatasetConnector`.

# teal.data 0.1.2

Expand Down
270 changes: 0 additions & 270 deletions R/CDISCTealData.R

This file was deleted.

Loading

0 comments on commit 36090d2

Please sign in to comment.