Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup-r-deps: replace github-token param with GITHUB_PAT env var #262

Merged
merged 3 commits into from
Nov 7, 2024
Merged

setup-r-deps: replace github-token param with GITHUB_PAT env var #262

merged 3 commits into from
Nov 7, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Nov 7, 2024 •
edited
Loading

Fix the issue when private repos cannot be accessed: https://github.com/insightsengineering/citril/actions/runs/11717635984/job/32642879518?pr=464

@pawelru pawelru marked this pull request as ready for review November 7, 2024 10:22
@pawelru pawelru requested a review from a team as a code owner November 7, 2024 10:22
@pawelru
Copy link
Contributor Author

pawelru commented Nov 7, 2024

tests succeeded: https://github.com/insightsengineering/citril/actions/runs/11720908954/job/32647246786

pawelru
pawelru commented Nov 7, 2024
View reviewed changes
.github/workflows/rhub.yaml Outdated Show resolved Hide resolved
pawelru
pawelru commented Nov 7, 2024
View reviewed changes
.github/workflows/rhub.yaml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024 •
edited
Loading

Unit Tests Summary

3 tests   3 ✅  6s ⏱️
3 suites  0 💤
1 files    0 ❌

Results for commit e376bcd.

♻️ This comment has been updated with latest results.

m7pr
m7pr approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you meant to set it as env global environment so it can be used in the R session, and not as a configuration parameter of the job, then this is OK!

@m7pr m7pr self-assigned this Nov 7, 2024
@m7pr m7pr added the core label Nov 7, 2024
@m7pr m7pr mentioned this pull request Nov 7, 2024
Merged
@cicdguy cicdguy merged commit d45f912 into main Nov 7, 2024
26 checks passed
@cicdguy cicdguy deleted the setup_r_deps_gh_pat branch November 7, 2024 13:26
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@m7pr m7pr m7pr approved these changes

@cicdguy cicdguy cicdguy approved these changes

Assignees

@m7pr m7pr

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pawelru @cicdguy @m7pr