-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review teal
documentation before release
#815
Comments
I'm going to make a running list of notes here.
|
code:
Add a filter for |
Checking you are on the filter refactor branch of teal and teal.slice (as I assume that's what will be released) |
Actually, we're only focusing on the one on main branch for this release. |
I was able to reproduce your experience, however, I was suspicious about this part: teal/R/module_tabs_with_filters.R Line 61 in e8a67d1
So I updated to this: datasets1 <- teal:::get_dummy_datasets()
datasets2 <- teal:::get_dummy_datasets() And now I can see it's working: Perhaps this have something to do with object addresses? or maybe the fact that |
I was able to run it the example: Any chance you were not using the main branch version of |
Just double checked. I'm on main for both teal and teal slice. And used devtools::load_all() for both packages to ensure the correct branch. Still getting the error. There's clearly something weird going on though. I've just run some more apps and numeric filters are giving errors. I also tried re-running staged.dependencies and using library(teal). No dice. |
@chlebowa @nikolas-burkoff @BLAZEWIM any chance you guys can try this? |
Only works for me if I
|
Regarding the errors with the range slider plot, I think this is an ggplot2/rlang issue. I had ggplot2 3.4.1 which correctly requires rlang >= 1.1.0. However for some reason I still had rlang 1.0.6 installed. I'll go back through the examples and update the bullets above. |
We're focusing on |
Summary
Related with insightsengineering/nestdevs-tasks#13
In preparation to release
teal
, we need to review/assess all documentation in the package.Acceptance Criteria
qenv
.qenv
chunks
(i.e. make sure the right language around deprecation)The text was updated successfully, but these errors were encountered: