-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #10 add ard_vif()
#61
Conversation
Code Coverage Summary
Diff against main
Results for commit: d48fb3c Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 29 suites 4s ⏱️ Results for commit d48fb3c. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 6c743b9 ♻️ This comment has been updated with latest results. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
- Coverage 99.49% 99.40% -0.09%
==========================================
Files 16 17 +1
Lines 789 838 +49
==========================================
+ Hits 785 833 +48
- Misses 4 5 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zdz2101 !! Let me know if you'd like to chat about any of the comments.
Signed-off-by: Daniel Sjoberg <[email protected]>
Signed-off-by: Daniel Sjoberg <[email protected]>
Signed-off-by: Zelos Zhu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Just a few comments. Also, can you add tests with non-syntactic names in the covariates? We want to also ensure that the processed non-syntactic names match those from ard_regression()
.
@zdz2101 thank you for making these updates! I made one small change to the Great update!! Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌷 🌷 🌷 🌷 🌷
What changes are proposed in this pull request?
added
ard_vif()
which is essentially a wrapper forcar::vif()
put into our ard structureProvide more detail here as needed.
Reference GitHub issue associated with pull request. e.g., 'closes #'
Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()
devtools::test_coverage()
Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.devtools::test_coverage()
When the branch is ready to be merged:
NEWS.md
with the changes from this pull request under the heading "# cards (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).