Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Variance Inflation Factor ARD #10

Closed
ddsjoberg opened this issue Jan 24, 2024 · 3 comments · Fixed by #61
Closed

Add Variance Inflation Factor ARD #10

ddsjoberg opened this issue Jan 24, 2024 · 3 comments · Fixed by #61

Comments

@ddsjoberg
Copy link
Collaborator

ddsjoberg commented Jan 24, 2024

Feature description

https://www.danieldsjoberg.com/gtsummary/reference/add_vif.html

If we need to add an additional package dependency, add it to Suggests, use the cards function to check whether it's installed, and be sure to add a minimum version that is at least the version required in gtsummary.

@ddsjoberg ddsjoberg added the enhancement New feature or request label Jan 24, 2024
@ddsjoberg ddsjoberg added gtsummary sme and removed enhancement New feature or request labels Jan 31, 2024
@ddsjoberg ddsjoberg added the ARD label Feb 8, 2024
@zdz2101 zdz2101 self-assigned this Feb 19, 2024
@zdz2101
Copy link
Contributor

zdz2101 commented Feb 19, 2024

Hey @ddsjoberg saw this was on the board for to-do, is the logic for this supposed to be like below?

`regression object` |> ard_regression() |> ard_vif() 

@ddsjoberg
Copy link
Collaborator Author

thanks @zdz2101 ! I think we can make this one 'regression model' |> ard_vif(). Does that sound like it will work?

@zdz2101
Copy link
Contributor

zdz2101 commented Feb 19, 2024

thanks @zdz2101 ! I think we can make this one 'regression model' |> ard_vif(). Does that sound like it will work?

makes sense too, so kinda like an enhanced ard_regression()

zdz2101 added a commit that referenced this issue Feb 22, 2024
@zdz2101 zdz2101 linked a pull request Feb 23, 2024 that will close this issue
12 tasks
zdz2101 added a commit that referenced this issue Mar 6, 2024
zdz2101 added a commit that referenced this issue Mar 8, 2024
ddsjoberg added a commit that referenced this issue Mar 8, 2024
**What changes are proposed in this pull request?**
added `ard_vif()` which is essentially a wrapper for `car::vif()` put
into our ard structure

Provide more detail here as needed.

**Reference GitHub issue associated with pull request.** _e.g., 'closes
#<issue number>'_



--------------------------------------------------------------------------------

Pre-review Checklist (if item does not apply, mark is as complete)
- [x] **All** GitHub Action workflows pass with a ✅
- [x] PR branch has pulled the most recent updates from master branch:
`usethis::pr_merge_main()`
- [x] If a bug was fixed, a unit test was added.
- [x] Code coverage is suitable for any new functions/features
(generally, 100% coverage for new code): `devtools::test_coverage()`
- [x] Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

- [x] If a bug was fixed, a unit test was added.
- [x] Run `pkgdown::build_site()`. Check the R console for errors, and
review the rendered website.
- [x] Code coverage is suitable for any new functions/features:
`devtools::test_coverage()`

When the branch is ready to be merged:
- [ ] Update `NEWS.md` with the changes from this pull request under the
heading "`# cards (development version)`". If there is an issue
associated with the pull request, reference it in parentheses at the end
update (see `NEWS.md` for examples).
- [x] **All** GitHub Action workflows pass with a ✅
- [ ] Approve Pull Request
- [ ] Merge the PR. Please use "Squash and merge" or "Rebase and merge".

---------

Signed-off-by: Daniel Sjoberg <[email protected]>
Signed-off-by: Zelos Zhu <[email protected]>
Co-authored-by: Daniel Sjoberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants