Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #103 update effectsize package and corresponding hedges_g code accordingly #153

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

zdz2101
Copy link
Contributor

@zdz2101 zdz2101 commented May 21, 2024

What changes are proposed in this pull request?
effectsize package had a bug related to calling the function hedges_g which was fixed with their most recent release, 0.8.8

Provide more detail here as needed.

Closes #103


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • If a new ard_*() function was added, it passes the ARD structural checks from cards::check_ard_structure().
  • If a new ard_*() function was added, set_cli_abort_call() has been set.
  • If a new ard_*() function was added and it depends on another package (such as, broom), is_pkg_installed("broom", reference_pkg = "cardx") has been set in the function call and the following added to the roxygen comments: @examplesIf do.call(asNamespace("cardx")$is_pkg_installed, list(pkg = "broom"", reference_pkg = "cardx"))
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cardx (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@zdz2101 zdz2101 linked an issue May 21, 2024 that may be closed by this pull request
6 tasks
@zdz2101
Copy link
Contributor Author

zdz2101 commented May 31, 2024

@ddsjoberg totally forgot I had this up, I'm pretty sure I did all the correct/necessary but still seem to run into the same error though its clearly fixed on their package

packageVersion("effectsize")
#> [1] '0.8.8'
effectsize::hedges_g(mpg ~ am, data = mtcars)
#> Hedges' g |         95% CI
#> --------------------------
#> -1.44     | [-2.21, -0.65]
#> 
#> - Estimated using pooled SD.

@ddsjoberg
Copy link
Collaborator

@ddsjoberg totally forgot I had this up, I'm pretty sure I did all the correct/necessary but still seem to run into the same error though its clearly fixed on their package

packageVersion("effectsize")
#> [1] '0.8.8'
effectsize::hedges_g(mpg ~ am, data = mtcars)
#> Hedges' g |         95% CI
#> --------------------------
#> -1.44     | [-2.21, -0.65]
#> 
#> - Estimated using pooled SD.

Thanks @zdz2101 ! Can you put together a small reprex illustrating the issue?

@zdz2101 zdz2101 requested a review from ddsjoberg May 31, 2024 20:58
@zdz2101 zdz2101 marked this pull request as ready for review May 31, 2024 20:58
Copy link
Contributor

github-actions bot commented May 31, 2024

badge

Code Coverage Summary

Filename                               Stmts    Miss  Cover    Missing
-----------------------------------  -------  ------  -------  ------------------------------------
R/ard_aod_wald_test.R                     78       8  89.74%   39-44, 94, 97
R/ard_attributes.survey.design.R           2       0  100.00%
R/ard_car_anova.R                         45       2  95.56%   62, 65
R/ard_car_vif.R                           61       2  96.72%   52, 86
R/ard_continuous.survey.design.R         194       2  98.97%   172, 182
R/ard_effectsize_cohens_d.R              102       2  98.04%   68, 121
R/ard_effectsize_hedges_g.R               90       2  97.78%   68, 120
R/ard_emmeans_mean_difference.R           70       0  100.00%
R/ard_proportion_ci.R                     90       5  94.44%   115-119
R/ard_regression_basic.R                  16       1  93.75%   46
R/ard_regression.R                        51       0  100.00%
R/ard_smd_smd.R                           68       5  92.65%   58, 84-87
R/ard_stats_anova.R                       95       0  100.00%
R/ard_stats_aov.R                         36       0  100.00%
R/ard_stats_chisq_test.R                  39       1  97.44%   39
R/ard_stats_fisher_test.R                 42       1  97.62%   42
R/ard_stats_kruskal_test.R                35       1  97.14%   38
R/ard_stats_mcnemar_test.R                79       2  97.47%   63, 105
R/ard_stats_mood_test.R                   48       1  97.92%   46
R/ard_stats_oneway_test.R                 38       0  100.00%
R/ard_stats_prop_test.R                   84       1  98.81%   43
R/ard_stats_t_test_onesample.R            40       0  100.00%
R/ard_stats_t_test.R                     111       2  98.20%   65, 111
R/ard_stats_wilcox_test_onesample.R       41       0  100.00%
R/ard_stats_wilcox_test.R                 98       2  97.96%   65, 117
R/ard_survey_svychisq.R                   37       1  97.30%   44
R/ard_survey_svyranktest.R                51       0  100.00%
R/ard_survey_svyttest.R                   50       0  100.00%
R/ard_survival_survdiff.R                 89       0  100.00%
R/ard_survival_survfit_diff.R             76       8  89.47%   31-34, 43-46
R/ard_survival_survfit.R                 174      13  92.53%   79-81, 85, 95-97, 128-132, 237
R/construction_helpers.R                  68      11  83.82%   154, 166-170, 196-200
R/proportion_ci.R                        195      28  85.64%   290, 293, 302-307, 315, 330, 438-461
TOTAL                                   2393     101  95.78%

Diff against main

Filename                       Stmts    Miss  Cover
---------------------------  -------  ------  -------
R/ard_effectsize_hedges_g.R       -7       0  -0.16%
TOTAL                             -7       0  -0.01%

Results for commit: fb33566

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented May 31, 2024

Unit Tests Summary

  1 files   71 suites   10s ⏱️
 71 tests  47 ✅ 24 💤 0 ❌
204 runs  168 ✅ 36 💤 0 ❌

Results for commit fb33566.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zdz2101 !!!

@ddsjoberg ddsjoberg merged commit bb01833 into main Jun 4, 2024
32 checks passed
@ddsjoberg ddsjoberg deleted the 103-require-new-version-of-effectsize branch June 4, 2024 18:05
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require new version of {effectsize}
2 participants