-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #103 update effectsize package and corresponding hedges_g code accordingly #153
Conversation
@ddsjoberg totally forgot I had this up, I'm pretty sure I did all the correct/necessary but still seem to run into the same error though its clearly fixed on their package packageVersion("effectsize")
#> [1] '0.8.8' effectsize::hedges_g(mpg ~ am, data = mtcars)
#> Hedges' g | 95% CI
#> --------------------------
#> -1.44 | [-2.21, -0.65]
#>
#> - Estimated using pooled SD. |
Thanks @zdz2101 ! Can you put together a small reprex illustrating the issue? |
Code Coverage Summary
Diff against main
Results for commit: fb33566 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 71 suites 10s ⏱️ Results for commit fb33566. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @zdz2101 !!!
What changes are proposed in this pull request?
effectsize
package had a bug related to calling the functionhedges_g
which was fixed with their most recent release,0.8.8
Provide more detail here as needed.
Closes #103
Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()
ard_*()
function was added, it passes the ARD structural checks fromcards::check_ard_structure()
.ard_*()
function was added,set_cli_abort_call()
has been set.ard_*()
function was added and it depends on another package (such as,broom
),is_pkg_installed("broom", reference_pkg = "cardx")
has been set in the function call and the following added to the roxygen comments:@examplesIf do.call(asNamespace("cardx")$is_pkg_installed, list(pkg = "broom"", reference_pkg = "cardx"))
devtools::test_coverage()
Reviewer Checklist (if item does not apply, mark is as complete)
devtools::test_coverage()
When the branch is ready to be merged:
NEWS.md
with the changes from this pull request under the heading "# cardx (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).