Require new version of {effectsize} #103
Comments
|
@zdz2101 the new effectsize is now on CRAN. Are you free to tackle this issue? |
13 tasks
13 tasks
ddsjoberg
pushed a commit
that referenced
this issue
Jun 4, 2024
… accordingly (#153) **What changes are proposed in this pull request?** `effectsize` package had a bug related to calling the function `hedges_g` which was fixed with their most recent release, `0.8.8` Provide more detail here as needed. Closes #103 -------------------------------------------------------------------------------- Pre-review Checklist (if item does not apply, mark is as complete) - [x] **All** GitHub Action workflows pass with a ✅ - [x] PR branch has pulled the most recent updates from master branch: `usethis::pr_merge_main()` - [x] If a bug was fixed, a unit test was added. - [x] If a new `ard_*()` function was added, it passes the ARD structural checks from `cards::check_ard_structure()`. - [x] If a new `ard_*()` function was added, `set_cli_abort_call()` has been set. - [x] If a new `ard_*()` function was added and it depends on another package (such as, `broom`), `is_pkg_installed("broom", reference_pkg = "cardx")` has been set in the function call and the following added to the roxygen comments: `@examplesIf do.call(asNamespace("cardx")$is_pkg_installed, list(pkg = "broom"", reference_pkg = "cardx"))` - [x] Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): `devtools::test_coverage()` Reviewer Checklist (if item does not apply, mark is as complete) - [ ] If a bug was fixed, a unit test was added. - [ ] Code coverage is suitable for any new functions/features: `devtools::test_coverage()` When the branch is ready to be merged: - [x] Update `NEWS.md` with the changes from this pull request under the heading "`# cardx (development version)`". If there is an issue associated with the pull request, reference it in parentheses at the end update (see `NEWS.md` for examples). - [x] **All** GitHub Action workflows pass with a ✅ - [ ] Approve Pull Request - [ ] Merge the PR. Please use "Squash and merge" or "Rebase and merge".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
in {effectsize} v0.8.7 there is a bug if
hedges_g()is namespaced vs not having the package loaded. see easystats/effectsize#636We've incorporated a temporary fix where we use {withr} to locally load the namespace to execute calls to
hedges_g()Once {effectsize} releases their new version with the fix, we will need to
withr::with_namespace()calls inard_hedges_g()andard_paired_hedges_g()withr::local_namespace()in the testing filesard_hedges_g()andard_paired_hedges_g()skip_if_not()in the unit testing file."hedges_g"fromutils::globalVariables()The text was updated successfully, but these errors were encountered: