-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cli call env functions #112
Conversation
Code Coverage Summary
Diff against main
Results for commit: 6524d09 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 56 suites 8s ⏱️ Results for commit 6524d09. ♻️ This comment has been updated with latest results. |
@ddsjoberg I believe we don't need to use Remotes here to specify the dependency since the standalone files are present in this repo as well and don't need to be taken from |
Hi @edelarua and @ayogasekaram , @ayogasekaram recently updated function names to follow our convention `ard_<pkg>_<fn>()`, and @edelarua added cli environment handling. Both updates resulted in a large number of changes to files and file names. This PR is going into @edelarua 's PR for adding the cli env handling (#112), and is meant to resolve all the conflicts. Can you both please review and approve this PR? Please check that I haven't undone any of your important changes from either initiative? Apologies for the incredibly poor planning on my part. 😬 --------- Signed-off-by: Daniel Sjoberg <[email protected]> Signed-off-by: Abinaya Yogasekaram <[email protected]> Co-authored-by: Abinaya Yogasekaram <[email protected]> Co-authored-by: ddsjoberg <[email protected]> Co-authored-by: Emily de la Rua <[email protected]>
…ineering/cardx into 42_cli_call_fun@main
@edelarua generally, yes I think that is true. In this case, since we are removing exported functions, if we had rouge calls to |
@ddsjoberg your changes look good!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WOWOW! Thank you so much @edelarua 😻
What changes are proposed in this pull request?
standalone
repo and implementset_cli_abort_call
in user-facing functions. (Implement cli call env functions #111, @edelarua)Closes #111
Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()
ard_*()
function was added, it passes the ARD structural checks fromcards::check_ard_structure()
.devtools::test_coverage()
Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.devtools::test_coverage()
When the branch is ready to be merged:
NEWS.md
with the changes from this pull request under the heading "# cards (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).