Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cli call env functions #112

Merged
merged 13 commits into from
Apr 15, 2024
Merged

Use cli call env functions #112

merged 13 commits into from
Apr 15, 2024

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Apr 10, 2024

What changes are proposed in this pull request?

Closes #111


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • If a new ard_*() function was added, it passes the ARD structural checks from cards::check_ard_structure().
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@edelarua edelarua added the sme label Apr 10, 2024
Copy link
Contributor

github-actions bot commented Apr 10, 2024

badge

Code Coverage Summary

Filename                        Stmts    Miss  Cover    Missing
----------------------------  -------  ------  -------  ------------------------------------
R/ard_aod_wald_test.R              77       8  89.61%   36-41, 91, 94
R/ard_car_anova.R                  45       2  95.56%   62, 65
R/ard_car_vif.R                    61       6  90.16%   37-40, 52, 86
R/ard_effectsize_cohens_d.R        88       2  97.73%   66, 111
R/ard_effectsize_hedges_g.R        82       2  97.56%   65, 115
R/ard_proportion_ci.R              42       5  88.10%   68-72
R/ard_regression_basic.R           15       1  93.33%   46
R/ard_regression.R                 50       0  100.00%
R/ard_smd_smd.R                    55       1  98.18%   48
R/ard_stats_anova.R               104      12  88.46%   120-126, 189-193
R/ard_stats_aov.R                  36       0  100.00%
R/ard_stats_chisq_test.R           39       1  97.44%   39
R/ard_stats_fisher_test.R          41       1  97.56%   39
R/ard_stats_kruskal_test.R         35       1  97.14%   38
R/ard_stats_mcnemar_test.R         49       1  97.96%   43
R/ard_stats_mood_test.R            48       1  97.92%   46
R/ard_stats_oneway_test.R          31       0  100.00%
R/ard_stats_prop_test.R            82       1  98.78%   40
R/ard_stats_t_test.R              110       2  98.18%   62, 108
R/ard_stats_wilcox_test.R          97       2  97.94%   62, 114
R/ard_survey_svychisq.R            37       1  97.30%   44
R/ard_survey_svycontinuous.R      193       2  98.96%   169, 179
R/ard_survey_svyranktest.R         51       0  100.00%
R/ard_survey_svyttest.R            50       0  100.00%
R/ard_survival_survfit.R          180       8  95.56%   78-80, 84, 94-96, 246
R/proportion_ci.R                 194      28  85.57%   290, 293, 302-307, 315, 330, 430-453
TOTAL                            1892      88  95.35%

Diff against main

Filename                        Stmts    Miss  Cover
----------------------------  -------  ------  --------
R/ard_aod_wald_test.R              +3      +2  -2.28%
R/ard_car_anova.R                  +4       0  +0.43%
R/ard_car_vif.R                    +3      +1  -1.22%
R/ard_effectsize_cohens_d.R        +1       0  +0.03%
R/ard_effectsize_hedges_g.R        +1       0  +0.03%
R/ard_proportion_ci.R              +2       0  +0.60%
R/ard_regression_basic.R           +1       0  +0.48%
R/ard_regression.R                 +1       0  +100.00%
R/ard_smd_smd.R                    +1       0  +0.03%
R/ard_stats_anova.R                +5      +3  -2.45%
R/ard_stats_aov.R                  +1       0  +100.00%
R/ard_stats_chisq_test.R           +1       0  +0.07%
R/ard_stats_fisher_test.R          +1       0  +0.06%
R/ard_stats_kruskal_test.R         +1       0  +0.08%
R/ard_stats_mcnemar_test.R         +1       0  +0.04%
R/ard_stats_mood_test.R            +1       0  +0.04%
R/ard_stats_oneway_test.R          +1       0  +100.00%
R/ard_stats_prop_test.R            +4       0  +0.06%
R/ard_stats_t_test.R              +14       0  +0.27%
R/ard_stats_wilcox_test.R          -8       0  -0.16%
R/ard_survey_svychisq.R            +1       0  +0.08%
R/ard_survey_svycontinuous.R       +1       0  +0.01%
R/ard_survey_svyranktest.R         +1       0  +100.00%
R/ard_survey_svyttest.R            +1       0  +100.00%
R/ard_survival_survfit.R           +7      +4  -2.13%
R/proportion_ci.R                  +6       0  +0.46%
TOTAL                             +56     +10  -0.40%

Results for commit: 6524d09

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Apr 10, 2024

Unit Tests Summary

  1 files   56 suites   8s ⏱️
 56 tests  37 ✅ 19 💤 0 ❌
152 runs  117 ✅ 35 💤 0 ❌

Results for commit 6524d09.

♻️ This comment has been updated with latest results.

@edelarua edelarua requested a review from ddsjoberg April 11, 2024 15:55
@edelarua
Copy link
Contributor Author

@ddsjoberg I believe we don't need to use Remotes here to specify the dependency since the standalone files are present in this repo as well and don't need to be taken from cards, but please correct me if I'm wrong!

ddsjoberg and others added 2 commits April 15, 2024 07:38
Hi @edelarua and @ayogasekaram , 

@ayogasekaram recently updated function names to follow our convention
`ard_<pkg>_<fn>()`, and @edelarua added cli environment handling. Both
updates resulted in a large number of changes to files and file names.

This PR is going into @edelarua 's PR for adding the cli env handling
(#112), and is meant to resolve all the conflicts. Can you both please
review and approve this PR? Please check that I haven't undone any of
your important changes from either initiative? Apologies for the
incredibly poor planning on my part. 😬

---------

Signed-off-by: Daniel Sjoberg <[email protected]>
Signed-off-by: Abinaya Yogasekaram <[email protected]>
Co-authored-by: Abinaya Yogasekaram <[email protected]>
Co-authored-by: ddsjoberg <[email protected]>
Co-authored-by: Emily de la Rua <[email protected]>
@ddsjoberg
Copy link
Collaborator

@ddsjoberg I believe we don't need to use Remotes here to specify the dependency since the standalone files are present in this repo as well and don't need to be taken from cards, but please correct me if I'm wrong!

@edelarua generally, yes I think that is true. In this case, since we are removing exported functions, if we had rouge calls to cards::is_pkg_installed() (namespaced calls) they wouldn't error unless we used Remotes pointing to cli env update in cards.

@edelarua
Copy link
Contributor Author

@ddsjoberg your changes look good!!

Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOWOW! Thank you so much @edelarua 😻

@ddsjoberg ddsjoberg merged commit b667d8d into main Apr 15, 2024
28 checks passed
@ddsjoberg ddsjoberg deleted the 42_cli_call_fun@main branch April 15, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement cli call env functions
2 participants