fix: enable ethpubkey

[beer-1]

Description

Closes: #XXXX

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• New Features

  • Enhanced client context with keyring options for improved key management.

• Bug Fixes

  • Improved error handling in application home directory checks for clearer error reporting.

[coderabbitai]

Walkthrough

The changes in this pull request involve modifications to two main files: app/ante/ante.go and cmd/minitiad/root.go. In ante.go, the signature verification decorator is updated to use a new implementation from the sigverify package, replacing the previous method. In root.go, import statements are adjusted, and the client context is enhanced with keyring options, improving configuration management and error handling in the application export process.

Changes

File Path	Change Summary
app/ante/ante.go	- Updated signature verification decorator from ante.NewSigVerificationDecorator to sigverify.NewSigVerificationDecorator. - Added import for sigverify package.
cmd/minitiad/root.go	- Updated imports: added cryptokeyring and removed params. - Enhanced initClientCtx with WithKeyringOptions(cryptokeyring.Option()). - Improved error handling in appExport method.

Poem

In the garden of code, where changes bloom,
A new sigverify decorates the room.
With keyring options, our context grows,
Error messages clearer, as progress flows.
Hopping through functions, we dance with glee,
Celebrating updates, as bright as can be! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between c3868ba and ba5f695.

📒 Files selected for processing (2)

• app/ante/ante.go (2 hunks)
• cmd/minitiad/root.go (2 hunks)

🔇 Additional comments (5)

app/ante/ante.go (3)

92-92: Clarify the different signature verification approaches.

The main ante handler uses the new sigverify.NewSigVerificationDecorator, while CreateAnteHandlerForOPinit continues to use ante.NewSigVerificationDecorator. Please clarify if this difference is intentional and if OPinit should also support Ethereum public keys.

#!/bin/bash
# Description: Check if OPinit has specific requirements preventing the use of the new decorator

# Look for OPinit-specific signature verification requirements
rg -A 5 -B 5 "OPinit.*signature|signature.*OPinit"

# Check if there are any documented limitations
fd -g "*.md" --exec rg -i "opinit.*signature|ethereum.*opinit"

Also applies to: 101-107

---

16-16: Verify the sigverify package implementation.

Given that this PR aims to enable ethpubkey functionality, let's verify that the new sigverify package properly handles Ethereum public key verification.

---

92-92: Verify security implications of the new signature verification decorator.

The change from ante.NewSigVerificationDecorator to sigverify.NewSigVerificationDecorator is a critical security modification. Please ensure:

1. The new implementation maintains all security guarantees of the original
2. It properly handles both existing and Ethereum public key verification
3. It has been thoroughly tested with different key types

cmd/minitiad/root.go (2)

36-38: LGTM: Import changes align with new keyring functionality.

The addition of the cryptokeyring package is necessary for the new keyring options being introduced.

---

91-92: Verify keyring configuration for Ethereum public key support.

The changes look good and align with the PR objective of enabling ethpubkey functionality. However, let's verify the keyring configuration:

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.39%. Comparing base (c3868ba) to head (ba5f695).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #68   +/-   ##
=======================================
  Coverage   77.39%   77.39%           
=======================================
  Files          14       14           
  Lines        1411     1411           
=======================================
  Hits         1092     1092           
  Misses        272      272           
  Partials       47       47           

Files with missing lines	Coverage Δ
app/ante/ante.go	66.66% <100.00%> (ø)