Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use custom sig verify gas consumer #72

Merged
merged 1 commit into from
Nov 5, 2024
Merged

fix: use custom sig verify gas consumer #72

merged 1 commit into from
Nov 5, 2024

Conversation

beer-1
Copy link
Member

@beer-1 beer-1 commented Nov 5, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Introduced a flexible fee checking mechanism for specific transactions, allowing certain transactions to bypass fees.
    • Enhanced gas consumption logic during signature verification.
  • Bug Fixes

    • Improved error handling for transaction type assertions.
  • Refactor

    • Updated the order of operations in the ante processing phase to improve efficiency.

@beer-1 beer-1 requested a review from a team as a code owner November 5, 2024 09:22
@beer-1 beer-1 self-assigned this Nov 5, 2024
Copy link

coderabbitai bot commented Nov 5, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request modifies the NewAnteHandler function in the app/ante/ante.go file, changing the signature gas consumer from ante.DefaultSigVerificationGasConsumer to sigverify.DefaultSigVerificationGasConsumer. It introduces a new function, freeLaneFeeChecker, to manage transactions in a "free lane" category, bypassing fee checks when applicable. Additionally, the order of anteDecorators has been updated to incorporate the new signature verification decorator. These changes enhance the ante handler's gas consumption logic and fee checking capabilities.

Changes

File Change Summary
app/ante/ante.go - Modified NewAnteHandler to use sigverify.DefaultSigVerificationGasConsumer.
- Added freeLaneFeeChecker function for handling "free lane" transactions.
- Updated the order of anteDecorators to include the new signature verification decorator.
- Updated method signature for NewAnteHandler (internal logic modified).
- Added method CreateAnteHandlerForOPinit.

Possibly related PRs

  • fix: enable ethpubkey #68: The changes in this PR also modify the NewAnteHandler function in app/ante/ante.go, specifically updating the signature verification decorator to use the sigverify package, which is directly related to the changes made in the main PR.

🐇 In the code we hop and play,
New handlers lead the way!
With fees that come and fees that go,
Our transactions now flow!
Signature checks, oh what a thrill,
In our free lane, we skip the bill!
🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@beer-1 beer-1 merged commit f43ac99 into main Nov 5, 2024
5 of 6 checks passed
@beer-1 beer-1 deleted the fix/ethpubkey branch November 5, 2024 09:26
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.78%. Comparing base (34e8f2d) to head (0176bb8).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   75.78%   75.78%           
=======================================
  Files          14       14           
  Lines        1441     1441           
=======================================
  Hits         1092     1092           
  Misses        302      302           
  Partials       47       47           
Files with missing lines Coverage Δ
app/ante/ante.go 66.66% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant