Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update some configs to let them enabled by default #30

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

Vritra4
Copy link
Contributor

@Vritra4 Vritra4 commented Apr 29, 2024

in app.toml

  • api.enable = true
  • api.swagger = true
  • api.address = tcp://0.0.0.0:1317
  • indexer.enabled = true
  • no indexer.l1-chain-id
    in config.toml
  • rpc.laddr = tcp:0.0.0.0:26657
  • rpc.cors-allowed-origins = ["*"]

@Vritra4 Vritra4 requested a review from beer-1 April 29, 2024 09:11
@Vritra4 Vritra4 self-assigned this Apr 29, 2024
@Vritra4
Copy link
Contributor Author

Vritra4 commented Apr 29, 2024

i'll make another prs for miniwasm/minievm once it's approved

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 57.86%. Comparing base (31013ba) to head (9e3b522).
Report is 1 commits behind head on main.

Files Patch % Lines
cmd/minitiad/config.go 0.00% 8 Missing ⚠️
cmd/minitiad/init.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   58.30%   57.86%   -0.44%     
==========================================
  Files          15       15              
  Lines        1602     1614      +12     
==========================================
  Hits          934      934              
- Misses        631      643      +12     
  Partials       37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This reverts commit 81ecc6a.
@Vritra4 Vritra4 merged commit d041e38 into main Apr 29, 2024
4 of 6 checks passed
@Vritra4 Vritra4 deleted the update-default-config branch April 29, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants