Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update some configs to let them enabled by defaul #30

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

Vritra4
Copy link
Contributor

@Vritra4 Vritra4 commented Apr 29, 2024

sams as this

@Vritra4 Vritra4 requested a review from beer-1 April 29, 2024 09:43
@Vritra4 Vritra4 self-assigned this Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 13.54%. Comparing base (d0b1ad2) to head (3eb754e).
Report is 3 commits behind head on main.

Files Patch % Lines
cmd/minitiad/config.go 0.00% 8 Missing ⚠️
cmd/minitiad/init.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   13.55%   13.54%   -0.01%     
==========================================
  Files          55       55              
  Lines       17778    17790      +12     
==========================================
  Hits         2410     2410              
- Misses      15178    15190      +12     
  Partials      190      190              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vritra4 Vritra4 merged commit 342a0e4 into main Apr 29, 2024
4 of 6 checks passed
@Vritra4 Vritra4 deleted the update-default-config branch April 29, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants