Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy to multiple environments #61

Merged
merged 5 commits into from
Jul 24, 2017

Conversation

ATMartin
Copy link
Contributor

@ATMartin ATMartin commented Jun 20, 2017

This builds on #57 by extending the current master branch, providing a clear explanation of use in our helptext, and tweaking some of the logging to make the process clearer.

Thanks to @Twistedst for their work on the base implementation!

Screenshots:

  • Help text:

screen shot 2017-06-20 at 2 24 52 am

  • Show all environment IDs in validation:

screen shot 2017-06-20 at 2 26 19 am

shawley33 and others added 5 commits June 20, 2017 06:21
When entering multiple environments, it's likely that users will add
spaces after commas. This prevents that from becoming a blocking issue
by stripping whitespace before processing. AWS disallows spaces in env
names, so this won't affect any currently-used environments.
@aldrinleal
Copy link
Member

Thanks! I'll take a look

@aldrinleal aldrinleal merged commit 6b6b0e6 into ingenieux:master Jul 24, 2017
@ghost
Copy link

ghost commented Jul 24, 2017

Merged and Released. Thank you sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants