Add Multiple Environment Functionality #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/br/com/ingenieux/jenkins/plugins/awsebdeployment/cmd/ZeroDowntime.java # src/main/resources/br/com/ingenieux/jenkins/plugins/awsebdeployment/AWSEBDeploymentBuilder/config.jelly
…updating the environment description when checking for the versions.
|
Sorry for the delay. It looks good, however: a. Make the PR smaller by removing references to deploy multiple, removing commented code and check your imports Once done I'll surely approve it. |
|
@Twistedst This is great - thank you! Are you considering updating this or would you mind if I fork your branch & clean it up here? Don't want to step on your toes if it's already on your TODO list! :) EDIT: This has been extended/updated at #61. 🚀 |
|
Sorry for not getting back to you all! I'm glad it helped! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now capable to use multiple environments using this format (env-foo, env-bar, env-yo). You can have from 1 to many environments. I added the changes to Zero Downtime as well, but did not test that as thoroughly. There may be some unnecessary changes in there, but I'm not sure what is and isn't. Feel free to edit it as you see fit.