This repository has been archived by the owner on Feb 6, 2021. It is now read-only.
Propigate close event when socket closes #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simlay
force-pushed
the
propigate-socket-closed-event
branch
from
269ff61 to
d52730d
Compare
|
Yeah, this is hard to test |
sehz
approved these changes
Jan 30, 2021
|
published |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help the rust and node client know when the socket is closed (like internet dropping) for infinyon/fluvio-client-node#43
I spent a bit of time trying to unit test this and found it to be annoying and cumbersome. Thoughts?