Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect TCP connection termination in CLI #678

Closed
sehz opened this issue Jan 12, 2021 · 4 comments
Closed

Detect TCP connection termination in CLI #678

sehz opened this issue Jan 12, 2021 · 4 comments
Assignees
Milestone

Comments

@sehz
Copy link
Contributor

sehz commented Jan 12, 2021

Both produce and consumer has continuous way to fetch producer and consumer. If connection to server goes down, it should immediately terminate it to give user good experience

Scope: If a Fluvio operation (e.g. consume) would stay open, but the connection is terminated, the CLI should gracefully exit and print a message describing what happened.

@sehz sehz added this to the 1.0-alpha-oss-3 milestone Jan 12, 2021
@sehz sehz self-assigned this Jan 12, 2021
@sehz sehz changed the title Tcp Keep Alive Detect TCP connection termination in Client/CLI Jan 13, 2021
@sehz sehz changed the title Detect TCP connection termination in Client/CLI Detect TCP connection termination in CLI Jan 13, 2021
@sehz sehz added the CLI label Jan 13, 2021
@sehz
Copy link
Contributor Author

sehz commented Jan 13, 2021

@nicholastmosher
Copy link
Contributor

Test if this is still a problem

@simlay
Copy link
Contributor

simlay commented Feb 2, 2021

infinyon/fluvio-socket#22 should have helped with this but because there's a new enum in FlvSocketError, the auth workspace doesn't like it due to the map_err. I didn't think it was a breaking change with infinyon/fluvio-socket#22 but maybe I was wrong.

@nicholastmosher
Copy link
Contributor

We need some lower-level machinery updates in order to gracefully handle the producer case of this issue. For now it should be sufficient for the CLI to timeout and print a message which is what happens today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants