Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow for DidMethod with partitioned namespace #75

Merged
merged 5 commits into from
May 13, 2024

Conversation

nanderstabel
Copy link
Collaborator

@nanderstabel nanderstabel commented May 7, 2024

Description of change

This change allows for DidMethod's with namespace support. For more information see #72, but in short:
now not just did:key, did:jwk and did:iota can be parsed to a DidMethod struct, but did:iota:smr and did:iota:rms are valid DidMethod's as well.

Disclaimer:
The SIOPv2 specification has a (probably unintended) too restrictive requirement regarding displaying supported DID Methods in a Providers metadata (that doesn't allow for namespaces). There is an open issue for this which will will hopefully result in this restriction to be removed: openid/SIOPv2#22.

Links to any relevant issues

How the change has been tested

Added unit test..

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nanderstabel nanderstabel linked an issue May 7, 2024 that may be closed by this pull request
1 task
@nanderstabel nanderstabel self-assigned this May 7, 2024
@nanderstabel nanderstabel added the Enhancement New feature or improvement to an existing feature label May 7, 2024
Base automatically changed from feat/async-traits to dev May 7, 2024 20:45
@nanderstabel nanderstabel force-pushed the feat/did-method-namespace branch from 7037b47 to 4185b47 Compare May 8, 2024 08:25
@nanderstabel nanderstabel changed the title WIP feat: allow for DidMethod with partitioned namespace May 8, 2024
@nanderstabel nanderstabel marked this pull request as ready for review May 8, 2024 13:27
@nanderstabel nanderstabel requested a review from daniel-mader May 8, 2024 13:27
@nanderstabel nanderstabel merged commit 7c6a6eb into dev May 13, 2024
1 check passed
@nanderstabel nanderstabel deleted the feat/did-method-namespace branch May 13, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement to an existing feature
Projects
Development

Successfully merging this pull request may close these issues.

Allow for DidMethod's with partitioned namespaces
2 participants