feat: add support for IOTA DID Method #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a test for the `POST` method for the `credentials` endpoint that updates the `CREDENTIAL_LOCATION` environment variable
nanderstabel
changed the title
nanderstabel
force-pushed
the
feat/did-manager-iota
branch
from
1a6b20c to
f2e097d
Compare
|
🎉 This PR is included in version 1.0.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR adds support for the IOTA DID Method. The implementation is rather simple since all of the related functionality is done by
did_manager'sSecretManager.However, because of IOTA DID Method's async nature, the previous versions of the
oid4vctraits where insufficient. This update utilizes an updatedoid4vcdependency that does support the necessary async traits needed for DID IOTA.Most of the code changes in this PR are simply the effect of normal trait methods to async trait methods. A bunch of tests had to be altered as well to support the async code.
Blocked by
DidMethodwith partitioned namespace openid4vc#75Links to any relevant issues
did:iotaidentities #17How the change has been tested
existing updated tests still pass
manual testing using UniMe
Definition of Done checklist
Add an
xto the boxes that are relevant to your changes.