Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Potential transfer bypass vulnerability #257

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Potential transfer bypass vulnerability #257

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b8eb07
Fix: Prevent transfer bypass vulnerability via malicious contracts
rickymcalister Jan 11, 2025
60b57fb
Correct doc block to reflect modified conditions for validateTransfer…
rickymcalister Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions contracts/allowlist/OperatorAllowlistEnforced.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,12 @@ abstract contract OperatorAllowlistEnforced is OperatorAllowlistEnforcementError
*/
modifier validateTransfer(address from, address to) {
// Check for:
// 1. caller is an EOA
// 2. caller is Allowlisted or is the calling address bytecode is Allowlisted
// 1. caller address is different from the transaction origin address
// 2. caller is an EOA
// 3. caller is Allowlisted or the calling address bytecode is Allowlisted
if (
msg.sender != tx.origin && // solhint-disable-line avoid-tx-origin
msg.sender.code.length != 0 &&
!operatorAllowlist.isAllowlisted(msg.sender)
) {
revert CallerNotInAllowlist(msg.sender);
Expand Down