Fix: Potential transfer bypass vulnerability #257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
validateTransfer
check appears to have a subtle flaw; it only checks ifmsg.sender
is different fromtx.origin
. It doesn't check ifmsg.sender
is a contract.A malicious EOA could potentially create a contract that simply calls the transfer function. Because
msg.sender
(the malicious contract's address) would be different fromtx.origin
(the malicious EOA's address), the allowlist check formsg.sender
would be bypassed. This means the malicious EOA could effectively transfer tokens even if their contract (and therefore indirectly, themselves) is not on the allowlist.The modifier should explicitly check if
msg.sender
is an EOA before skipping the allowlist check.