Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added button to contribution guidelines and COC #130

Closed
wants to merge 3 commits into from
Closed

added button to contribution guidelines and COC #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18fbb2c
added button to contribution guidelines and COC
nlok5923 Sep 27, 2020
54b813c
added target attribute
nlok5923 Sep 29, 2020
006fae3
margin added to repo-links div
nlok5923 Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions public/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ input:-webkit-autofill:active {
background: transparent;
}

.repo-links {
position: relative;
margin-top: 15px;
}

footer {
position: absolute;
right: 0;
Expand Down
8 changes: 6 additions & 2 deletions views/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,14 +96,18 @@
<br>
<button class="uk-button uk-margin-top uk-border-pill
uk-button-default"
type="submit" onclick="showToast()">Submit</button>
type="submit" onclick="showToast()">Submit</button><br />
<div class ="repo-links">
<a class="uk-text-center uk-button uk-button-default uk-border-pill uk-margin-small-top" target="_blank" href="https://github.com/iiitv/getmein-web/blob/master/CONTRIBUTING.md">CONTRIBUTION GUIDELINES</a>
<a class="uk-text-center uk-button uk-button-default uk-border-pill uk-margin-small-top" target="_blank" href="https://github.com/iiitv/getmein-web/blob/master/CODE_OF_CONDUCT.md">CODE OF CONDUCT </a>
</div>
</form>
</div>
<div class="message uk-text-center uk-text-success"></div>
</main>


<footer class="uk-align-center uk-text-center">
<footer class="uk-align-center uk-text-center uk-margin-remove">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure about removing this?
The margins don't look right. The page is also showing a disabled scrollbar and the footer content is being cut due to screen size.

Can we just calmly write some CSS to make sure content fits in 100vh always?

image

<hr class="uk-divider-icon">
<a uk-tooltip="title: GitHub; pos: left" class="uk-icon-button
uk-margin-small-right" href="https://git.io/iiitv" uk-icon="github"></a>
Expand Down