Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added button to contribution guidelines and COC #130

Closed
wants to merge 3 commits into from
Closed

added button to contribution guidelines and COC #130

wants to merge 3 commits into from

Conversation

nlok5923
Copy link
Member

@nlok5923 nlok5923 commented Sep 27, 2020

Description

Added button for contribution guidelines and code of conduct.

Screenshot Before Change:

Screenshot (1387)

Screenshot After Change:

Screenshot (1386)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Non Functional Requirement

  • Follows the code style of this project.
  • Tests Cover Changes
  • I have performed a self-review of my own code
  • All new and existing tests passed.
  • Documentation

deployment link : https://nlok5923-getmein-web-7.glitch.me/

@nlok5923
Copy link
Member Author

@iiitv/project-maintainers please review this pull request.

Copy link
Member

@theyashshahs theyashshahs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nlok5923 add 20px margin between the repo links and the submit button same as that between the span tag and the submit button.

@nlok5923
Copy link
Member Author

nlok5923 commented Sep 30, 2020

After changes :
test link : https://nlok5923-getmein-web-8.glitch.me/

Screenshot (1389)

</form>
</div>
<div class="message uk-text-center uk-text-success"></div>
</main>


<footer class="uk-align-center uk-text-center">
<footer class="uk-align-center uk-text-center uk-margin-remove">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure about removing this?
The margins don't look right. The page is also showing a disabled scrollbar and the footer content is being cut due to screen size.

Can we just calmly write some CSS to make sure content fits in 100vh always?

image

@nlok5923
Copy link
Member Author

nlok5923 commented Oct 2, 2020

@aashutoshrathi Sir, there isn't much space for buttons while maintaining the same space as it is between the submit button and span element. that's why i has to apply uk-margin-remove to the footer div . but sir if we has to keep footer in the same way as before we has to go with this implementation while keeping the page fits in 100vh .

Screenshot (1401)

or if we can make page scrollable we can go with buttons.
sir if there any other possible option please let me know.

@nlok5923 nlok5923 closed this Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants