Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code of conduct and contributing btns. #123

Closed
wants to merge 5 commits into from
Closed

Added code of conduct and contributing btns. #123

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef42472
Update index.html
nlok5923 Sep 22, 2020
e087938
Update style.css
nlok5923 Sep 22, 2020
a522917
Update style.css
nlok5923 Sep 22, 2020
053bd57
Update index.html
nlok5923 Sep 22, 2020
22f422a
Update index.html
nlok5923 Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions public/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
body {
margin: 25px;
overflow-y: scroll;
position: fixed;
position:fixed;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is space here removed?

top: 0;
bottom: 0;
left: 0;
Expand Down Expand Up @@ -45,7 +45,6 @@ input:-webkit-autofill:active {
}

footer {
position: absolute;
right: 0;
bottom: 0;
left: 0;
Expand Down
15 changes: 13 additions & 2 deletions views/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
<label class="tgl-btn" for="toggleTheme"></label>

<!-- Header -->
<header class="uk-text-center uk-align-center uk-width-1-1">
<header class="uk-text-center uk-align-center uk-width-1-1 uk-margin">
<img src="https://avatars3.githubusercontent.com/u/9347727?s=150&v=4">
<div class="uk-text-center uk-text-large uk-text-bold">
GetMeIn
Expand Down Expand Up @@ -97,13 +97,24 @@
<button class="uk-button uk-margin-top uk-border-pill
uk-button-default"
type="submit" onclick="showToast()">Submit</button>
<br>
<span class="uk-text-success uk-text-meta uk-text-center uk-margin">Also take a look at </span>
<br>
<a href="https://github.com/iiitv/getmein-web/blob/master/CODE_OF_CONDUCT.md">
<button class="uk-button uk-margin-top uk-border-pill
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are using uk-button the wrong way here.
When we have links, we should approach it like this.

<a class="uk-button uk-margin-top uk-border-pill uk-button-default" 
    href="https://github.com/iiitv/getmein-web/blob/master/CODE_OF_CONDUCT.md"
    Code of Conduct
</a>

uk-button-default">CODE OF CONDUCT</button></a>
<br>
</a>
<a href="https://github.com/iiitv/getmein-web/blob/master/CONTRIBUTING.md">
<button class="uk-button uk-margin-top uk-border-pill
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, don't use the button element directly.

uk-button-default">CONTRIBUTION GUIDELINES</button></a>
</form>
</div>
<div class="message uk-text-center uk-text-success"></div>
</main>


<footer class="uk-align-center uk-text-center">
<footer class="uk-align-center uk-text-center uk-margin-remove">
<hr class="uk-divider-icon">
<a uk-tooltip="title: GitHub; pos: left" class="uk-icon-button
uk-margin-small-right" href="https://git.io/iiitv" uk-icon="github"></a>
Expand Down