Added code of conduct and contributing btns. #123
Conversation
|
Sir please have a look to the site : https://nlok5923-getmein-web-1.glitch.me/
|
|
okay sir working on it. |
views/index.html
Outdated
| @@ -97,13 +97,24 @@ | |||
| <button class="uk-button uk-margin-top uk-border-pill | |||
| uk-button-default" | |||
| type="submit" onclick="showToast()">Submit</button> | |||
| <br><br> | |||
There was a problem hiding this comment.
Use uk-margin-top in element below it instead <br/>
| <span class="uk-text-success uk-text-meta uk-text-center uk-margin">Also take a look at </span> | ||
| <br> | ||
| <a href="https://github.com/iiitv/getmein-web/blob/master/CODE_OF_CONDUCT.md"> | ||
| <button class="uk-button uk-margin-top uk-border-pill |
There was a problem hiding this comment.
You are using uk-button the wrong way here.
When we have links, we should approach it like this.
<a class="uk-button uk-margin-top uk-border-pill uk-button-default"
href="https://github.com/iiitv/getmein-web/blob/master/CODE_OF_CONDUCT.md"
Code of Conduct
</a>| <br> | ||
| </a> | ||
| <a href="https://github.com/iiitv/getmein-web/blob/master/CONTRIBUTING.md"> | ||
| <button class="uk-button uk-margin-top uk-border-pill |
There was a problem hiding this comment.
Same here, don't use the button element directly.
| @@ -12,7 +12,7 @@ | |||
| body { | |||
| margin: 25px; | |||
| overflow-y: scroll; | |||
| position: fixed; | |||
| position:fixed; | |||
There was a problem hiding this comment.
Why is space here removed?
|
Also, @nlok5923 Your commit messages indicate you are using GitHub Web GUI to edit files. |
|
Yep, please write meaningful commit messages/descriptions to indicate what the change does. GUI 👎 |
|
okay sir sorry for using Web ui i will create a new pull request. |
Fixes
Description
Added button to take a look at contributing guidelines and code of conduct.
Screenshot Before Change:
Screenshot After Change:
Types of changes
Non Functional Requirement