Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IMU parent link names for gz-sim-yarp-plugins #254

Conversation

xela-95
Copy link
Contributor

@xela-95 xela-95 commented Aug 7, 2024

By checking if the modifications introduced by #253 were also working on the modern Gazebo, I found a mistake I made in #250.

@xela-95
Copy link
Contributor Author

xela-95 commented Aug 7, 2024

CC @Nicogene @traversaro

@xela-95
Copy link
Contributor Author

xela-95 commented Aug 7, 2024

BTW, I should implement a smoke test to be run automatically by the CI in order to not having to do this manually every time 😅

@traversaro
Copy link
Member

BTW, I should implement a smoke test to be run automatically by the CI in order to not having to do this manually every time 😅

Yes, I think an executable that just loads the model, checks if the yarprobotinterface loaded correctly and shut downs and report if success or failure would be quite useful.

@Nicogene Nicogene merged commit 0aae999 into icub-tech-iit:automatic-update-urdf-1723040404 Aug 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants