Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Move loop_root sentinel value above exhaustive conditionals #616

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Bugfix: Move loop_root sentinel value above exhaustive conditionals #616

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30ddf30
Bugfix: Move loop_root sentinel value above exhaustive conditionals
mfisher87 Sep 25, 2024
8cbbcbe
Merge branch 'development' into bugfix-misplaced-sentinel-value
JessicaS11 Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions icepyx/core/granules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,13 +412,13 @@
status = statuslist[0]
print("Initial status of your order request at NSIDC is: ", status)

loop_root = None

Check warning on line 415 in icepyx/core/granules.py

View check run for this annotation

Codecov / codecov/patch

icepyx/core/granules.py#L415 

Added line #L415 was not covered by tests
# If status is already finished without going into pending/processing
if status.startswith("complete"):
loop_response = self.session.get(statusURL)
loop_root = ET.fromstring(loop_response.content)

# Continue loop while request is still processing
loop_root = None
while status == "pending" or status == "processing":
print(
"Your order status is still ",
Expand All @@ -443,11 +443,10 @@
continue

if not isinstance(loop_root, ET.Element):
# The typechecker determined that loop_root could be unbound at this
# point. We know for sure this shouldn't be possible, though, because
# the while loop should run once.
# See: https://github.com/microsoft/pyright/discussions/2033
raise RuntimeError("Programmer error!")
# The typechecker needs help knowing that at this point loop_root is
# set, as it can't tell that the conditionals above are supposed to be
# exhaustive.
raise icepyx.core.exceptions.ExhaustiveTypeGuardException

Check warning on line 449 in icepyx/core/granules.py

View check run for this annotation

Codecov / codecov/patch

icepyx/core/granules.py#L449 

Added line #L449 was not covered by tests

# Order can either complete, complete_with_errors, or fail:
# Provide complete_with_errors error message:
Expand Down