Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Move loop_root sentinel value above exhaustive conditionals #616

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

mfisher87
Copy link
Member

@mfisher87 mfisher87 commented Sep 25, 2024

The development branch doesn't pass integration tests due to this mistake introduced in #593.

@mfisher87 mfisher87 added review::quick This change should not require more than 10 minutes to review review::priority This change is preferred for review labels Sep 25, 2024
Copy link

github-actions bot commented Sep 25, 2024

Binder 👈 Launch a binder notebook on this branch for commit dda2184

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit e2dbf32

Binder 👈 Launch a binder notebook on this branch for commit 30ddf30

Binder 👈 Launch a binder notebook on this branch for commit 8cbbcbe

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.68%. Comparing base (74ca632) to head (8cbbcbe).
Report is 1 commits behind head on development.

Files with missing lines Patch % Lines
icepyx/core/granules.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #616      +/-   ##
===============================================
- Coverage        71.48%   66.68%   -4.80%     
===============================================
  Files               38       36       -2     
  Lines             3135     3077      -58     
  Branches           600      594       -6     
===============================================
- Hits              2241     2052     -189     
- Misses             783      935     +152     
+ Partials           111       90      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfisher87 mfisher87 force-pushed the bugfix-misplaced-sentinel-value branch from e2dbf32 to 30ddf30 Compare September 25, 2024 23:53
@JessicaS11 JessicaS11 merged commit 4e54d0a into development Sep 26, 2024
7 of 9 checks passed
@JessicaS11 JessicaS11 deleted the bugfix-misplaced-sentinel-value branch September 26, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review::priority This change is preferred for review review::quick This change should not require more than 10 minutes to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants