Add option to export patterns #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
…om/ibi-group/datatools-server into add-option-for-publishing-patterns
…ary files with comments
br648
approved these changes
Nov 14, 2023
5 tasks
miles-grant-ibigroup
approved these changes
Nov 15, 2023
| @@ -63,6 +63,12 @@ private static Snapshot getSnapshotFromRequest(Request req) { | |||
| return Persistence.snapshots.getById(id); | |||
| } | |||
|
|
|||
| private static boolean getPublishProprietaryFiles(Request req) { | |||
| return Boolean.parseBoolean( | |||
| req.queryParamOrDefault("publishProprietaryFiles",Boolean.FALSE.toString()) | |||
There was a problem hiding this comment.
Suggested change
| req.queryParamOrDefault("publishProprietaryFiles",Boolean.FALSE.toString()) | |
| req.queryParamOrDefault("publishProprietaryFiles", Boolean.FALSE.toString()) |
Missing space
| @@ -130,7 +130,8 @@ public void jobLogic() { | |||
| snapshot.feedTransformResult = dbTarget.feedTransformResult; | |||
| // If the user has selected to create a new version from the resulting snapshot, do so here. | |||
| if (rules.createNewVersion) { | |||
| addNextJob(new CreateFeedVersionFromSnapshotJob(feedSource, snapshot, owner)); | |||
| // Publishing the proprietary files will preserve the pattern names in the newly created feed version. | |||
| addNextJob(new CreateFeedVersionFromSnapshotJob(feedSource, snapshot, owner, true)); | |||
There was a problem hiding this comment.
This feels like a scary new default. How are we sure this won't have weird side effects?
There was a problem hiding this comment.
This is a safe default bc the method is only used to process incoming GTFS files. All the export methods allow for user selection if they want to export the pattern names and this just allows re-import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
This PR facilitates the export of the proprietary
datatools_patterns.txtfile, introduced in https://github.com/conveyal/gtfs-lib/pulls, which allows the preservation of custom pattern names in the editor.Front end PR: https://github.com/ibi-group/datatools-ui/compare/add-option-for-publishing-patterns?expand=1
GTFS-lib PR: conveyal/gtfs-lib#394