Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for publishing patterns #991

Merged
merged 8 commits into from
Nov 21, 2023

Conversation

philip-cline
Copy link
Contributor

@philip-cline philip-cline commented Oct 6, 2023

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This PR provides the user an option to export a feed with the proprietary datatools_patterns.txt file, introduced in https://github.com/conveyal/gtfs-lib/pulls, which allows the preservation of custom pattern names in the editor.

For testing:
Server PR: ibi-group/datatools-server#567
GTFS-Lib PR: conveyal/gtfs-lib#394

Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean! Just a bit of cleanup and language changes needed

i18n/english.yml Outdated Show resolved Hide resolved
i18n/english.yml Outdated Show resolved Hide resolved
__tests__/end-to-end.js Show resolved Hide resolved
lib/common/components/ExportPatternsModal.js Show resolved Hide resolved
lib/editor/components/CreateSnapshotModal.js Show resolved Hide resolved
Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All making sense now thanks

Copy link
Contributor

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, thanks!

i18n/english.yml Outdated
@@ -87,6 +87,9 @@ components:
placeholder: Additional information (optional)
publishNewVersion:
label: Publish snapshot as new feed version
publishProprietaryFiles:
helpText: Proprietary files allow you to maintain certain Datatools features when re-importing, such as pattern names.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
helpText: Proprietary files allow you to maintain certain Datatools features when re-importing, such as pattern names.
helpText: Proprietary files allow you to maintain certain Datatools features, such as pattern names, when re-importing a feed.

@philip-cline philip-cline added BLOCKED Blocked (waiting on another PR to be merged) and removed BLOCKED Blocked (waiting on another PR to be merged) labels Nov 15, 2023
@philip-cline philip-cline merged commit 6f2de56 into dev Nov 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants