-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for publishing patterns #991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean! Just a bit of cleanup and language changes needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All making sense now thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, thanks!
i18n/english.yml
Outdated
@@ -87,6 +87,9 @@ components: | |||
placeholder: Additional information (optional) | |||
publishNewVersion: | |||
label: Publish snapshot as new feed version | |||
publishProprietaryFiles: | |||
helpText: Proprietary files allow you to maintain certain Datatools features when re-importing, such as pattern names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
helpText: Proprietary files allow you to maintain certain Datatools features when re-importing, such as pattern names. | |
helpText: Proprietary files allow you to maintain certain Datatools features, such as pattern names, when re-importing a feed. |
Checklist
dev
before they can be merged tomaster
)Description
This PR provides the user an option to export a feed with the proprietary
datatools_patterns.txt
file, introduced in https://github.com/conveyal/gtfs-lib/pulls, which allows the preservation of custom pattern names in the editor.For testing:
Server PR: ibi-group/datatools-server#567
GTFS-Lib PR: conveyal/gtfs-lib#394