Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8824: The popup for custom tags with multiple fields is not scrollable #183

Merged
merged 11 commits into from
Sep 30, 2024
Merged

IBX-8824: The popup for custom tags with multiple fields is not scrollable #183

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
17641ee
IBX-8824: The popup for custom tags with multiple fields is not scrol…
lucasOsti Sep 6, 2024
214f84d
After CR
lucasOsti Sep 10, 2024
ac3260e
After CR
lucasOsti Sep 12, 2024
24051e5
After QA
lucasOsti Sep 16, 2024
e3a3fc6
After QA
lucasOsti Sep 17, 2024
6b6225b
After QA
lucasOsti Sep 18, 2024
348c5cf
Prettier
lucasOsti Sep 18, 2024
73c6307
afetr QA
lucasOsti Sep 18, 2024
540253b
After CR
lucasOsti Sep 19, 2024
824e0e3
Fixes after QA
tischsoic Sep 30, 2024
64c0537
Remove needless calls to setPanelContentMaxHeight
tischsoic Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/bundle/Resources/public/js/CKEditor/custom-tags/block-custom-tag/custom-tag-ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,22 @@ class IbexaCustomTagUI extends Plugin {
this.addCustomTag = this.addCustomTag.bind(this);

this.isNew = false;
this.lastClassListValue = null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver/observe#attributeoldvalue
there is dedicated option for it in mutation observer :)

this.observer = new MutationObserver((mutationList) => {
for (const mutation of mutationList) {
if (this.lastClassListValue !== mutation.target.classList.value) {
if (this.lastClassListValue !== null) {
setPanelContentMaxHeight(this.balloon.view);
}

this.lastClassListValue = mutation.target.classList.value;
}
}
});

this.observer.observe(this.balloon.view.element, {
attributes: true,
});
}

isCustomTagSelected(eventData) {
Expand Down
Loading