Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8824: The popup for custom tags with multiple fields is not scrollable #183

Merged
merged 11 commits into from
Sep 30, 2024

Conversation

lucasOsti
Copy link
Contributor

🎫 Issue IBX-8824

Description:

For QA:

Documentation:

@lucasOsti lucasOsti changed the base branch from main to 4.6 September 6, 2024 12:25
@lucasOsti lucasOsti requested a review from tischsoic September 12, 2024 10:52
Copy link

@barbaragr barbaragr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I've found an issue:

  1. Go to creating an article
  2. Paste some text into richtext field
  3. Somewhere in the middle insert added custom tag
  4. Don't fill the fields in CT, just click save
  5. Click settings button and the edit button in custom tag
  6. Try to scroll to the top
    Actual result: Top of the custom tag is still covered. See attachment, please.
    https://github.com/user-attachments/assets/a77eaf4e-016c-4a3e-829b-5dad652fd586

@alongosz
Copy link
Member

Note: 4.6 CI fix is pending review, via #184

@barbaragr
Copy link

Still covers the very last element in menu when it's displayed below custom tag... 😅

Screen.Recording.2024-09-17.at.15.43.55.mov

Copy link

@KamilSznajdrowicz KamilSznajdrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I've found an issue:

  1. Go to creating an article
  2. Paste some text into richtext field
  3. Enter distraction-free mode.
  4. Somewhere in the middle insert added custom tag
  5. Try to scroll to the top
    Actual result: A window with a scrollbar appears in the wrong place. See attachment, please.
Nagranie.z.ekranu.2024-09-18.o.14.58.31.mov

@@ -19,6 +19,22 @@ class IbexaCustomTagUI extends Plugin {
this.addCustomTag = this.addCustomTag.bind(this);

this.isNew = false;
this.lastClassListValue = null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

sonarcloud bot commented Sep 30, 2024

Copy link

@KamilSznajdrowicz KamilSznajdrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot reproduce

Hi, I've found new an issue:
The popup disappears when we start scrolling the page up and down quickly. The error occurs in both regular and distraction-free mode.
1. Go to creating an article
2. Paste some text into richtext field
3. Somewhere in the middle insert added custom tag
4. Scroll the page up and down quickly.
Please see the attachment:
https://github.com/user-attachments/assets/1d7df575-1bfd-45fd-b2f2-605407d5e233

@dew326 dew326 merged commit 2ef456b into 4.6 Sep 30, 2024
21 checks passed
@dew326 dew326 deleted the IBX-8824 branch September 30, 2024 12:07
@tischsoic
Copy link
Contributor

Merged up:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants