Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hot fix seg. fault when there is not enough hits to calculate the track length #106

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

dudarboh
Copy link
Member

BEGINRELEASENOTES

  • Fix a seg. fault, in rare cases, when the track fit fails in both directions due to the lack of hits.

ENDRELEASENOTES

Found out that around 2.2% of my jobs seg. faulted because of that. Few cases, which i encountered, had tracks with 3-6 hits in total.
I am not sure, how the track successfully created in the first place, as I have tried to keep fit procedure as similar to the production code as possible.

@tmadlener
Copy link
Contributor

gcc CI builds seem to pick up the wrong version of LCIO during linking. iLCSoft/LCIO#150 has removed virtual from all LCRelationNavigator functionality.

@tmadlener
Copy link
Contributor

Same as for #107, will wait for the key4hep-stack to pick up the newest version of LCIO and make sure things build there before merging. I will rebase this once #107 has been merged.

@tmadlener tmadlener force-pushed the fix_track_length_seg_fault branch from 5567ae6 to 855dc39 Compare December 6, 2022 13:44
@tmadlener
Copy link
Contributor

merging, since key4hep-nightlies based workflow is happy.

@tmadlener tmadlener merged commit 79e69dc into iLCSoft:master Dec 6, 2022
@dudarboh dudarboh deleted the fix_track_length_seg_fault branch December 6, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants