Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode RecoParticle relation weights more explicit #108

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Encode RecoParticle relation weights more explicit #108

merged 2 commits into from
Feb 7, 2023

Conversation

dudarboh
Copy link
Member

@dudarboh dudarboh commented Feb 3, 2023

BEGINRELEASENOTES

  • Make encoding RecoParticle relation weights more explicit with a new encode function in MarlinUtil

ENDRELEASENOTES

tmadlener
tmadlener approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge this once, iLCSoft/MarlinUtil#36 has been picked up by the nightly builds tomorrow.

Analysis/RecoMCTruthLink/src/RecoMCTruthLinker.cc Outdated Show resolved Hide resolved
@tmadlener
Copy link
Contributor

The one CI workflow that is currently still failing is due to picking up different versions of LCIO while building and linking. We already had this in #106 and #107.

@tmadlener tmadlener merged commit c3a9946 into iLCSoft:master Feb 7, 2023
@dudarboh dudarboh deleted the update_mc_truth_relation_linker branch February 9, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dudarboh @tmadlener