Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-2935 #8066

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Update EIP-2935 #8066

merged 5 commits into from
Jan 7, 2025

Conversation

siladu
Copy link
Contributor

@siladu siladu commented Dec 23, 2024 •
edited
Loading

Update HISTORY_STORAGE_ADDRESS and HISTORY_SERVE_WINDOW for EIP-2935

Fixes #8061

PR description

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@siladu siladu changed the title [DO NOT MERGE] Update EIP-2935 Update EIP-2935 Dec 23, 2024
@siladu siladu mentioned this pull request Dec 23, 2024
Draft
@siladu siladu added the Prague label Jan 6, 2025
siladu added 3 commits January 7, 2025 12:05
@siladu
Merge remote-tracking branch 'upstream/main' into update-eip-2935
b941997 
Signed-off-by: Simon Dudley <[email protected]>
@siladu
Update HISTORY_STORAGE_ADDRESS and genesis code in tests.
9ac33bb 
Even for unrelated tests, this has a knock-on impact on the state root due to the history storage account being created when the BlockHashProcessor runs for block 1

Signed-off-by: Simon Dudley <[email protected]>
@siladu
Merge remote-tracking branch 'upstream/main' into update-eip-2935
b1b9125 
Signed-off-by: Simon Dudley <[email protected]>
@siladu siladu marked this pull request as ready for review January 7, 2025 05:09
jframe
jframe approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siladu siladu merged commit fa9ca9c into hyperledger:main Jan 7, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jframe jframe jframe approved these changes

Assignees
No one assigned
Labels
Prague
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Another Update to EIP-2935 implementation
2 participants
@siladu @jframe