Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pectra Devnet 5 Interop Test #8044

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

siladu
Copy link
Contributor

@siladu siladu commented Dec 18, 2024

Based on #8042

Plus cherry picked commits from
#8036 (daniellehrner:feat/issue-7947/exclude_empty_requests_hash)
#8029 (daniellehrner:feat/issue-8028/7702_7251_address_code_changes)
#7997 (daniellehrner:feat/issue-7994/eip-7623)

git cherry-pick 770ee68ec1d8a299dd2333a865afd044ae1e440c
git cherry-pick ac361cd55b5efed206a7033cc1ef2f6879814339
git cherry-pick 657fc4552dd511e0d140099535d1e3d85aeb49cf
git cherry-pick a80eda4b21ab2e2308fabbc56c1dd130bd3c295d
git cherry-pick 2fa9022433f9bfb12c3ca8d45520ba7b8fffb3ee
git cherry-pick db0808cd8d39f2123830c53f66d2b6dd47cb1636

Also included a locally squashed version of #8057 in 9480fe4 (#8044)

Including bug fix (since merged into main): c72d02e

git cherry-pick c72d02ea38721f73828954787917a55789ca10f8

Including #8066

git cherry-pick aea35a0e8ab4e51e2d42e81f62a875c2a9b726d0

To run with Kurtosis locally:
./gradlew distDocker -x :ethereum:evmtool:distDocker

pectra-devnet5.yml:

participants:
  - el_type: besu
    el_image: siladu/besu:24.12-develop-cb1357e
    cl_type: teku
    cl_image: consensys/teku:develop
    el_log_level: "info"
    count: 1
network_params:
  electra_fork_epoch: 1
  min_validator_withdrawability_delay: 1
  shard_committee_period: 1
  churn_limit_quotient: 16
  num_validator_keys_per_node: 256
additional_services:
  - dora
  - spamoor_blob
  - tx_spammer
dora_params:
  image: "ethpandaops/dora:master-latest"
snooper_enabled: true

spamoor_blob_params:
  throughput: 10
  max_blobs: 2
  max_pending: 40

siladu and others added 21 commits December 17, 2024 22:24
Signed-off-by: Simon Dudley <[email protected]>
…or each fork

This isolates defaulting to MainnetProtocolSpecs and reduces blast radius for tests

Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
- Add asMap for blobSchedule so it appears in admin_nodeInfo
- Prememptively add OsakaTargetingGasLimitCalculator and wire in the max blob count

Add blobschedule to mainnet.json to be explicit, since the code will default to the same values anyway

Signed-off-by: Simon Dudley <[email protected]>
…nstead of responding with error

Would fix hyperledger#8055 but unit tests still todo

Signed-off-by: Simon Dudley <[email protected]>
https://github.com/ethereum/EIPs/pull/9097/files
https://github.com/ethereum/EIPs/pull/9098/files
https://github.com/ethereum/EIPs/pull/9116/files

Signed-off-by: garyschulte <[email protected]>

adjust unit test gas costs, fix offset-by-one bug in the discount table

Signed-off-by: garyschulte <[email protected]>

implement bump in gas cost for bls map functions according to ethereum/EIPs@92c94cf

Signed-off-by: garyschulte <[email protected]>

using Pawel's suggested discount table from ethereum/EIPs#9116 (comment)

Signed-off-by: garyschulte <[email protected]>

use bls pairing costs from https://github.com/ethereum/EIPs/pull/9098/files

Signed-off-by: garyschulte <[email protected]>

remove MUL per ethereum/EIPs#8945

Signed-off-by: garyschulte <[email protected]>

fix g1 msm max discount case, add g2 msm max discount case

Signed-off-by: garyschulte <[email protected]>

remove bls mul ops from benchmark subcommand

Signed-off-by: garyschulte <[email protected]>

use besu-native 1.1.1

Signed-off-by: garyschulte <[email protected]>
* prague fee market for blob gas

Signed-off-by: garyschulte <[email protected]>

* Fix wiring and unit test

Signed-off-by: Simon Dudley <[email protected]>

---------

Signed-off-by: garyschulte <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Co-authored-by: Simon Dudley <[email protected]>
…params instead of responding with error"

This reverts commit c5e564c.

Signed-off-by: Simon Dudley <[email protected]>
* don't throw if all the gasprice params are specified

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
@siladu siladu force-pushed the pectra-devnet-5-interop branch from 4831117 to bd514ac Compare December 22, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants