Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update withdrawal request address #8016

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

macfarla
Copy link
Contributor

Signed-off-by: Sally MacFarlane [email protected]

PR description

Per EIP change ethereum/EIPs#9119 (files)

also renamed json file to match naming convention

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane [email protected]

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
@@ -131,7 +133,7 @@
"stdout": {
"alloc": {
"0x0000000000000000000000000000000000001000": {
"code": "0x60386000600037600060006038600060017309fc772d0857550724b07b850a4323f39112aaaa620f4240f150",
"code": "0x6038600060003760006000603860006001730c15f14308530b7cdb8460094bbb9cc28b9aaaaa620f4240f150",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proxy contract calls the withdrawal request address so it's updated here in the code also

@macfarla macfarla self-assigned this Dec 11, 2024
@macfarla macfarla merged commit 7e58f58 into hyperledger:main Dec 11, 2024
43 checks passed
@macfarla macfarla deleted the wdrwl-request-addr branch December 11, 2024 10:35
daniellehrner pushed a commit to daniellehrner/besu that referenced this pull request Dec 18, 2024
* rename file to match convention
* allow comments
* updated withdrawal request contract address

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants